Bug 191591 – Add support for RTCRtpCodecParameters.sdpFmtpLine

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Add support for RTCRtpCodecParameters.sdpFmtpLine

[youenn fablet]

Created attachment 354680 [details]
Patch

[Eric Carlson]

Comment on attachment 354680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354680&action=review

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:144
> +        sdpFmtpLineBuilder.appendLiteral("=");

Nit: I have always heard that sdpFmtpLineBuilder.appendLiteral.append('=') is more efficient

[youenn fablet]

Created attachment 354804 [details]
Patch for landing

[youenn fablet]

Thanks for the review.

(In reply to Eric Carlson from comment #2)
> Comment on attachment 354680 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=354680&action=review
> 
> > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:144
> > +        sdpFmtpLineBuilder.appendLiteral("=");
> 
> Nit: I have always heard that sdpFmtpLineBuilder.appendLiteral.append('=')
> is more efficient

Fixed.

[WebKit Commit Bot]

Comment on attachment 354804 [details]
Patch for landing

Clearing flags on attachment: 354804

Committed r238172: <https://trac.webkit.org/changeset/238172>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46062380>