Bug 191591 - Add support for RTCRtpCodecParameters.sdpFmtpLine
Summary: Add support for RTCRtpCodecParameters.sdpFmtpLine
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-13 10:13 PST by youenn fablet
Modified: 2018-11-14 07:22 PST (History)
4 users (show)

See Also:


Attachments
Patch (4.63 KB, patch)
2018-11-13 10:20 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (4.60 KB, patch)
2018-11-14 06:43 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-11-13 10:13:05 PST
Add support for RTCRtpCodecParameters.sdpFmtpLine
Comment 1 youenn fablet 2018-11-13 10:20:36 PST
Created attachment 354680 [details]
Patch
Comment 2 Eric Carlson 2018-11-13 17:40:48 PST
Comment on attachment 354680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354680&action=review

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:144
> +        sdpFmtpLineBuilder.appendLiteral("=");

Nit: I have always heard that sdpFmtpLineBuilder.appendLiteral.append('=') is more efficient
Comment 3 youenn fablet 2018-11-14 06:43:10 PST
Created attachment 354804 [details]
Patch for landing
Comment 4 youenn fablet 2018-11-14 07:13:35 PST
Thanks for the review.

(In reply to Eric Carlson from comment #2)
> Comment on attachment 354680 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=354680&action=review
> 
> > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:144
> > +        sdpFmtpLineBuilder.appendLiteral("=");
> 
> Nit: I have always heard that sdpFmtpLineBuilder.appendLiteral.append('=')
> is more efficient

Fixed.
Comment 5 WebKit Commit Bot 2018-11-14 07:21:54 PST
Comment on attachment 354804 [details]
Patch for landing

Clearing flags on attachment: 354804

Committed r238172: <https://trac.webkit.org/changeset/238172>
Comment 6 WebKit Commit Bot 2018-11-14 07:21:56 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-11-14 07:22:25 PST
<rdar://problem/46062380>