Add support for RTCRtpCodecParameters.sdpFmtpLine
Created attachment 354680 [details] Patch
Comment on attachment 354680 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354680&action=review > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:144 > + sdpFmtpLineBuilder.appendLiteral("="); Nit: I have always heard that sdpFmtpLineBuilder.appendLiteral.append('=') is more efficient
Created attachment 354804 [details] Patch for landing
Thanks for the review. (In reply to Eric Carlson from comment #2) > Comment on attachment 354680 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=354680&action=review > > > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:144 > > + sdpFmtpLineBuilder.appendLiteral("="); > > Nit: I have always heard that sdpFmtpLineBuilder.appendLiteral.append('=') > is more efficient Fixed.
Comment on attachment 354804 [details] Patch for landing Clearing flags on attachment: 354804 Committed r238172: <https://trac.webkit.org/changeset/238172>
All reviewed patches have been landed. Closing bug.
<rdar://problem/46062380>