Bug 191590 – Convert libwebrtc error types to DOM exceptions

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Convert libwebrtc error types to DOM exceptions

[youenn fablet]

Created attachment 354674 [details]
Patch

[youenn fablet]

Created attachment 354683 [details]
Patch

[Alex Christensen]

Comment on attachment 354683 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354683&action=review

> Source/WebCore/Configurations/WebCore.xcconfig:132
> -OTHER_LDFLAGS_PLATFORM_macosx = -sub_library libobjc -umbrella WebKit;
> +OTHER_LDFLAGS_PLATFORM_macosx = -sub_library libobjc -umbrella WebKit -Xlinker --no-demangle;

I'm not sure this is a good change.

[youenn fablet]

(In reply to Alex Christensen from comment #3)
> Comment on attachment 354683 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=354683&action=review
> 
> > Source/WebCore/Configurations/WebCore.xcconfig:132
> > -OTHER_LDFLAGS_PLATFORM_macosx = -sub_library libobjc -umbrella WebKit;
> > +OTHER_LDFLAGS_PLATFORM_macosx = -sub_library libobjc -umbrella WebKit -Xlinker --no-demangle;
> 
> I'm not sure this is a good change.

No, this is a left over whenever I need to get the missing libwebrtc symbols from WebCore.

[youenn fablet]

Created attachment 354803 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 354803 [details]
Patch for landing

Rejecting attachment 354803 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 354803, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=354803&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=191590&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 354803 from bug 191590.
Fetching: https://bugs.webkit.org/attachment.cgi?id=354803
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/imported/w3c/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/LayoutTests/imported/w3c/ChangeLog' is out of date
W: 050e581182172808f7db14c1e18b761017bdb2bb and refs/remotes/origin/master differ, using rebase:
:040000 040000 3f331fc9d76c76b81af22d91cb31ee0eda08d360 3a57aab666c93a6c8d45277a2d03f5e6b50cd9cf M	LayoutTests
:040000 040000 db54de69ef7e893209471a083b9f5aca9d092878 1e775a7d81e1a9d1dd8e5d11a092c89d870ed1f3 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/imported/w3c/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/LayoutTests/imported/w3c/ChangeLog' is out of date
W: 050e581182172808f7db14c1e18b761017bdb2bb and refs/remotes/origin/master differ, using rebase:
:040000 040000 3f331fc9d76c76b81af22d91cb31ee0eda08d360 3a57aab666c93a6c8d45277a2d03f5e6b50cd9cf M	LayoutTests
:040000 040000 db54de69ef7e893209471a083b9f5aca9d092878 1e775a7d81e1a9d1dd8e5d11a092c89d870ed1f3 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   d3d42633dcd..eca99bb3218  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 238170 = d3d42633dcd73cff6bf9e5e9aca979d4348ab463
r238171 = eca99bb321807d6e40cb987864dbb974b8eeea81
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/9988799

[youenn fablet]

Created attachment 354816 [details]
Rebasing

[WebKit Commit Bot]

Comment on attachment 354816 [details]
Rebasing

Clearing flags on attachment: 354816

Committed r238182: <https://trac.webkit.org/changeset/238182>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46065874>