Bug 191589 – RTCPeerConnection.getTransceivers is not always exposing all transceivers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

See imported/w3c/web-platform-tests/webrtc/RTCRtpTransceiver.https.html for one such case.

[youenn fablet]

Created attachment 354673 [details]
Patch

[Eric Carlson]

Comment on attachment 354673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354673&action=review

> Source/WebCore/Modules/mediastream/RTCPeerConnection.h:136
> +    const Vector<std::reference_wrapper<RTCRtpSender>>& getSenders() const;
> +    const Vector<std::reference_wrapper<RTCRtpReceiver>>& getReceivers() const;
> +    const Vector<RefPtr<RTCRtpTransceiver>>& getTransceivers() const;
> +
> +    const Vector<std::reference_wrapper<RTCRtpSender>>& senders() const { return m_transceiverSet->senders(); }
> +    const Vector<RefPtr<RTCRtpTransceiver>>& transceivers() const { return m_transceiverSet->list(); }

It isn't at all clear why we have both getSenders() and senders(), and getTransceivers() and transceivers(). Maybe "get" should be "collect", or "senders" should be "cachedSenders"?

[youenn fablet]

(In reply to Eric Carlson from comment #2)
> Comment on attachment 354673 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=354673&action=review
> 
> > Source/WebCore/Modules/mediastream/RTCPeerConnection.h:136
> > +    const Vector<std::reference_wrapper<RTCRtpSender>>& getSenders() const;
> > +    const Vector<std::reference_wrapper<RTCRtpReceiver>>& getReceivers() const;
> > +    const Vector<RefPtr<RTCRtpTransceiver>>& getTransceivers() const;
> > +
> > +    const Vector<std::reference_wrapper<RTCRtpSender>>& senders() const { return m_transceiverSet->senders(); }
> > +    const Vector<RefPtr<RTCRtpTransceiver>>& transceivers() const { return m_transceiverSet->list(); }
> 
> It isn't at all clear why we have both getSenders() and senders(), and
> getTransceivers() and transceivers(). Maybe "get" should be "collect", or
> "senders" should be "cachedSenders"?

Right, let's rename them currentSenders/Receivers/Transceivers.

[youenn fablet]

*** Bug 191588 has been marked as a duplicate of this bug. ***

[youenn fablet]

Created attachment 354704 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 354704 [details]
Patch for landing

Clearing flags on attachment: 354704

Committed r238150: <https://trac.webkit.org/changeset/238150>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46044314>