Bug 191580 - Remove WebKitTestRunnerLib's build warnings.
Summary: Remove WebKitTestRunnerLib's build warnings.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-13 00:45 PST by Takashi Komori
Modified: 2018-11-13 02:06 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.18 KB, patch)
2018-11-13 00:56 PST, Takashi Komori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Takashi Komori 2018-11-13 00:45:59 PST 
Remove WebKitTestRunnerLib's build warnings.

Building WebKitTestRunnerLib for WinCairo produces many redefinition warnings.
This is because wtf/Platform.h is included ahead cmakeconfig.h, through precompiled header (WebKitTestRunnerPrefix.h)

To remove these warnings we should include cmakeconfig.h in WebKitTestRunnerPrefix.h
Comment 1 Takashi Komori 2018-11-13 00:56:30 PST 
Created attachment 354659 [details]
Patch
Comment 2 WebKit Commit Bot 2018-11-13 02:05:24 PST 
Comment on attachment 354659 [details]
Patch

Clearing flags on attachment: 354659

Committed r238127: <https://trac.webkit.org/changeset/238127>
Comment 3 WebKit Commit Bot 2018-11-13 02:05:25 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-11-13 02:06:25 PST 
<rdar://problem/46022189>