Both of these functions do a lot of work. It would be good for the topCallFrame to be correct should we need to throw an exception. <rdar://problem/45942472>
Created attachment 354655 [details] proposed patch.
Created attachment 354656 [details] proposed patch.
Created attachment 354658 [details] proposed patch.
Comment on attachment 354658 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=354658&action=review > Source/JavaScriptCore/ChangeLog:39 > + frame #25: JSC::ProxyObject::getOwnPropertySlotCommon(this=0x000062d000200e40, exec=0x000062d00002c048, propertyName=PropertyName @ 0x00007ffeefbbba80, slot=0x00007ffeefbbc720) at ProxyObject.cpp:372 Can you also file a bug and assign it to me with a reproducible test case. calculatedClassName should not do anything effectful. So it’s wrong that it calls into JS
r=me if you want to land this patch
(In reply to Saam Barati from comment #4) > Can you also file a bug and assign it to me with a reproducible test case. > calculatedClassName should not do anything effectful. So it’s wrong that it > calls into JS I've filed https://bugs.webkit.org/show_bug.cgi?id=191594 to capture this issue. Thanks for the review. Landed in r238141: <http://trac.webkit.org/r238141>.