Bug 191578 - [GStreamer][MSE][Debug] Several debug tests are crashing after r238084
Summary: [GStreamer][MSE][Debug] Several debug tests are crashing after r238084
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-12 22:40 PST by Xabier Rodríguez Calvar
Modified: 2018-11-16 10:15 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.35 KB, patch)
2018-11-16 05:09 PST, Alicia Boya García 		no flags Details | Formatted Diff | Diff
Patch (2.62 KB, patch)
2018-11-16 09:24 PST, Alicia Boya García 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Xabier Rodríguez Calvar 2018-11-12 22:41:24 PST 
Both GTK and WPE Debug testing bots are unhappy.
Comment 2 Alicia Boya García 2018-11-13 10:36:56 PST 
Caps notifications are being emitted from the main thread when setting the pipeline to NULL state, unexpectedly (therefore the failed assertion).

The weird part is that so far this is only happening in the bots, even though we I am running supposedly the same GStreamer version from the jhbuild, with the same WebKit commit and the same test.

It may be worth it to investigate why it only fails in the bots. As for actually fixing the assertion error, all event handlers should be disconnected before tearing down the pipeline.
Comment 3 Alicia Boya García 2018-11-16 05:02:48 PST 
I've been able to reproduce the issue reliably after updating my system to F29... or maybe just the moons moved to the correct place. Either way, the error makes sense, here is a patch:
Comment 4 Alicia Boya García 2018-11-16 05:09:37 PST 
Created attachment 355044 [details]
Patch
Comment 5 Xabier Rodríguez Calvar 2018-11-16 09:17:45 PST 
Comment on attachment 355044 [details]
Patch

We are assuming that isMainThread() => !caps, which I think is dangerous. We should at least ASSERT on that
Comment 6 Alicia Boya García 2018-11-16 09:24:53 PST 
Created attachment 355065 [details]
Patch
Comment 7 WebKit Commit Bot 2018-11-16 10:14:52 PST 
Comment on attachment 355065 [details]
Patch

Clearing flags on attachment: 355065

Committed r238287: <https://trac.webkit.org/changeset/238287>
Comment 8 WebKit Commit Bot 2018-11-16 10:14:54 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-11-16 10:15:29 PST 
<rdar://problem/46130553>