Bug 191575 – Web Inspector: Styles: shift-clicking on a property should extend selection

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

When there's at least one property is selected, shift-clicking another property of the same rule should extend the selection.

This behavior should be similar to the one in macOS Finder.

[Radar WebKit Bug Importer]

<rdar://problem/46012855>

[Nikita Vasilyev]

Created attachment 354619 [details]
Patch

[Nikita Vasilyev]

Created attachment 354620 [details]
[Animated GIF] With patch applied

[Nikita Vasilyev]

This doesn't patch depends on Bug 191435 - Web Inspector: Styles: Command-A should select all properties.
It doesn't apply to master.

[Nikita Vasilyev]

Created attachment 354700 [details]
Patch

[Nikita Vasilyev]

Created attachment 354725 [details]
Patch

I implemented Shift-ArrowUp/ArrowDown keys, too. It was only two lines of code :)

[Nikita Vasilyev]

Created attachment 354732 [details]
Patch

Fix assertions.

[Nikita Vasilyev]

*** Bug 191125 has been marked as a duplicate of this bug. ***

[Devin Rousso]

Comment on attachment 354732 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354732&action=review

r=me, with some design feedback/changes

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:57
> +    set focusIndex(value)

It seems odd that setting the `focusIndex` would automatically select something.  I'd rather you extend/rework `selectProperties` to assume `_anchorIndex` when not supplied, or just provide a way for callers to access `_anchorIndex`.

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:476
> +        window.addEventListener("click", this._handleWindowMouseUp.bind(this), {capture: true, once: true});

Please rename this to `_handleWindowClick`

[Nikita Vasilyev]

Created attachment 354851 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 354851 [details]
Patch

Clearing flags on attachment: 354851

Committed r238201: <https://trac.webkit.org/changeset/238201>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.