Bug 191574 – Include AirPlay destination name in AirPlay placard.

• Status: NEW
• Component: Media

[Jeremy Jones]

Include tv name in AirPlay placard.

[Jeremy Jones]

rdar://problem/45536144

[Jeremy Jones]

Created attachment 354617 [details]
Patch

[EWS Watchlist]

Comment on attachment 354617 [details]
Patch

Attachment 354617 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9966587

New failing tests:
media/modern-media-controls/airplay-support/airplay-support.html
media/modern-media-controls/placard-support/placard-support-airplay.html
media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html

[EWS Watchlist]

Created attachment 354624 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 354617 [details]
Patch

Attachment 354617 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9966707

New failing tests:
media/modern-media-controls/airplay-support/airplay-support.html
media/modern-media-controls/placard-support/placard-support-airplay.html
media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html

[EWS Watchlist]

Created attachment 354625 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 354617 [details]
Patch

Attachment 354617 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9967354

New failing tests:
media/modern-media-controls/airplay-support/airplay-support.html
media/modern-media-controls/placard-support/placard-support-airplay.html
media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html

[EWS Watchlist]

Created attachment 354643 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Antoine Quint]

Comment on attachment 354617 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354617&action=review

I think we can now remove "This video is playing on your Apple TV" from the localized string and remove the description set in the AirplayPlacard constructor.

r- because of the test regressions.

> Source/WebCore/Modules/modern-media-controls/media/placard-support.js:77
> +        var type = this.mediaController.host.externalDeviceType;

We should be using a switch here, assuming there's a known list of options returned by externalDeviceType.

> Source/WebCore/Modules/modern-media-controls/media/placard-support.js:79
> +            deviceName = UIString("This video is playing on â%sâ.", this.mediaController.host.externalDeviceDisplayName || "Apple TV");

I think "Apple TV" needs to be added as a localized string.

> Source/WebCore/en.lproj/modern-media-controls-localized-strings.js:3
> +    "This video is playing on the TV.": "This video is playing on the TV.",

These should be alphabetically sorted.

[Jeremy Jones]

Comment on attachment 354617 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354617&action=review

>> Source/WebCore/Modules/modern-media-controls/media/placard-support.js:77
>> +        var type = this.mediaController.host.externalDeviceType;
> 
> We should be using a switch here, assuming there's a known list of options returned by externalDeviceType.

Done.

>> Source/WebCore/Modules/modern-media-controls/media/placard-support.js:79
>> +            deviceName = UIString("This video is playing on â%sâ.", this.mediaController.host.externalDeviceDisplayName || "Apple TV");
> 
> I think "Apple TV" needs to be added as a localized string.

Done.

>> Source/WebCore/en.lproj/modern-media-controls-localized-strings.js:3
>> +    "This video is playing on the TV.": "This video is playing on the TV.",
> 
> These should be alphabetically sorted.

Done.

[Jeremy Jones]

(In reply to Antoine Quint from comment #9)
> Comment on attachment 354617 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=354617&action=review
> 
> I think we can now remove "This video is playing on your Apple TV" from the
> localized string and remove the description set in the AirplayPlacard
> constructor.
> 

Done.

[Jeremy Jones]

Created attachment 354701 [details]
Patch

[EWS Watchlist]

Comment on attachment 354701 [details]
Patch

Attachment 354701 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9977822

New failing tests:
media/modern-media-controls/airplay-placard/airplay-placard.html
media/modern-media-controls/airplay-placard/airplay-placard-text-section.html
media/modern-media-controls/media-controls/media-controls-placard-compressed-metrics.html

[EWS Watchlist]

Created attachment 354711 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 354701 [details]
Patch

Attachment 354701 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9977789

New failing tests:
media/modern-media-controls/airplay-placard/airplay-placard.html
media/modern-media-controls/airplay-placard/airplay-placard-text-section.html
media/modern-media-controls/media-controls/media-controls-placard-compressed-metrics.html

[EWS Watchlist]

Created attachment 354717 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 354701 [details]
Patch

Attachment 354701 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9978390

New failing tests:
media/modern-media-controls/airplay-placard/airplay-placard.html
media/modern-media-controls/airplay-placard/airplay-placard-text-section.html
media/modern-media-controls/media-controls/media-controls-placard-compressed-metrics.html

[EWS Watchlist]

Created attachment 354723 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 354701 [details]
Patch

Attachment 354701 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9978359

New failing tests:
media/modern-media-controls/airplay-placard/airplay-placard.html
media/modern-media-controls/airplay-placard/airplay-placard-text-section.html
media/modern-media-controls/media-controls/media-controls-placard-compressed-metrics.html

[EWS Watchlist]

Created attachment 354727 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Jeremy Jones]

Created attachment 354842 [details]
Patch

[Eric Carlson]

Comment on attachment 354842 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354842&action=review

> Source/WebCore/ChangeLog:3
> +        Include tv name in AirPlay placard.

Nit: a/tv/TV/

[Jeremy Jones]

Created attachment 355091 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 355091 [details]
Patch for landing.

Clearing flags on attachment: 355091

Committed r238307: <https://trac.webkit.org/changeset/238307>