Bug 191560 - Web Inspector: REGRESSION(r236540): Debugger: breakpoints are sorted alphabetically instead of numerically
Summary: Web Inspector: REGRESSION(r236540): Debugger: breakpoints are sorted alphabet...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 182406
Blocks:
  Show dependency tree / graph
 
Reported: 2018-11-12 13:28 PST by Devin Rousso
Modified: 2018-11-14 14:40 PST (History)
6 users (show)

See Also:

Attachments
[Image] Screenshot of Issue (39.29 KB, image/png)
2018-11-12 13:29 PST, Devin Rousso 		no flags Details
Patch (3.60 KB, patch)
2018-11-12 13:33 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
[Image] Unable to reproduce (125.27 KB, image/png)
2018-11-12 13:41 PST, Matt Baker 		no flags Details
[Image] Unable to reproduce (non-prettyprinted source) (143.18 KB, image/png)
2018-11-12 13:45 PST, Matt Baker 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-11-12 13:28:51 PST 
.
Comment 1 Devin Rousso 2018-11-12 13:29:14 PST 
Created attachment 354584 [details]
[Image] Screenshot of Issue
Comment 2 Devin Rousso 2018-11-12 13:33:35 PST 
Created attachment 354586 [details]
Patch
Comment 3 Matt Baker 2018-11-12 13:41:19 PST 
Created attachment 354588 [details]
[Image] Unable to reproduce

They appear sorted numerically to me. I wonder what the difference is.
Comment 4 Matt Baker 2018-11-12 13:45:06 PST 
Created attachment 354589 [details]
[Image] Unable to reproduce (non-prettyprinted source)
Comment 5 Devin Rousso 2018-11-12 13:51:28 PST 
(In reply to Matt Baker from comment #3)
> They appear sorted numerically to me. I wonder what the difference is.
Try setting a breakpoint on a line > 1000.  I think the "," is what's tripping up the sorting.
Comment 6 Joseph Pecoraro 2018-11-12 13:53:40 PST 
Comment on attachment 354586 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2018-11-14 14:39:33 PST 
Comment on attachment 354586 [details]
Patch

Clearing flags on attachment: 354586

Committed r238202: <https://trac.webkit.org/changeset/238202>
Comment 8 WebKit Commit Bot 2018-11-14 14:39:34 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-11-14 14:40:58 PST 
<rdar://problem/46075952>