Bug 191558 - [IntersectionObserver] Support having targets in multiple windows
Summary: [IntersectionObserver] Support having targets in multiple windows
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ali Juma
URL:
Keywords:
Depends on:
Blocks: 159475
  Show dependency treegraph
 
Reported: 2018-11-12 12:56 PST by Ali Juma
Modified: 2018-11-12 13:39 PST (History)
10 users (show)

See Also:


Attachments
Patch (18.45 KB, patch)
2018-11-12 13:07 PST, Ali Juma
no flags Details | Formatted Diff | Diff
Patch (18.42 KB, patch)
2018-11-12 13:11 PST, Ali Juma
ajuma: review?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ali Juma 2018-11-12 12:56:32 PST
An implicit-root IntersectionObserver should be able to have targets in multiple windows, and observe the intersection of each of them with their window's viewport.
Comment 1 Ali Juma 2018-11-12 13:07:46 PST
Created attachment 354579 [details]
Patch
Comment 2 Build Bot 2018-11-12 13:09:26 PST
Attachment 354579 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ali Juma 2018-11-12 13:11:01 PST
Created attachment 354580 [details]
Patch
Comment 4 Simon Fraser (smfr) 2018-11-12 13:33:48 PST
Comment on attachment 354579 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354579&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

Fix this.
Comment 5 Ali Juma 2018-11-12 13:39:15 PST
(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 354579 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=354579&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests (OOPS!).
> 
> Fix this.

Removed that line in the latest patch since there's a web platform test that covers this (and passes after this patch).

Is that sufficient test coverage or do you think we need more?