Bug 191555 - Rollout 238026: It caused ~8% JetStream 2 regressions on some iOS devices
Summary: Rollout 238026: It caused ~8% JetStream 2 regressions on some iOS devices
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-12 12:40 PST by Saam Barati
Modified: 2018-11-12 14:11 PST (History)
7 users (show)

See Also:

Attachments
patch for landing (11.50 KB, patch)
2018-11-12 12:52 PST, Saam Barati 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
patch for landing (11.51 KB, patch)
2018-11-12 13:32 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-11-12 12:40:54 PST 
...
Comment 1 Saam Barati 2018-11-12 12:52:53 PST 
Created attachment 354574 [details]
patch for landing
Comment 2 WebKit Commit Bot 2018-11-12 13:23:44 PST 
Comment on attachment 354574 [details]
patch for landing

Rejecting attachment 354574 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 354574, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/9961961
Comment 3 Saam Barati 2018-11-12 13:32:24 PST 
Created attachment 354585 [details]
patch for landing
Comment 4 WebKit Commit Bot 2018-11-12 14:10:47 PST 
Comment on attachment 354585 [details]
patch for landing

Clearing flags on attachment: 354585

Committed r238109: <https://trac.webkit.org/changeset/238109>
Comment 5 WebKit Commit Bot 2018-11-12 14:10:48 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-11-12 14:11:29 PST 
<rdar://problem/46002795>