Bug 191553 – Web Inspector: Canvas: don't start with auto-capture enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

If the user has previously turned off auto-capture but still had a non-zero frame count, opening the Canvas tab shouldn't re-enable auto-capture.

[Devin Rousso]

Created attachment 354569 [details]
Patch

[Matt Baker]

Comment on attachment 354569 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354569&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js:226
>              this._recordingAutoCaptureFrameCountInputElement.style.setProperty("width", (textMetrics.width + 8) + "px");

Out of curiosity, where does the 8px come from? It looks like it comes from canvasOverviewContentView.css:184:

.navigation-bar > .item.canvas-recording-auto-capture > label > input {
    width: 1.5em;
    min-width: 1.5em;
    margin: 0 4px;
    text-align: center;
}

If so this should be a const, with a comment warning to keep it in sync with the stylesheet. I know this is off topic for this patch, but I noticed it while reading the file for context.

[Devin Rousso]

Created attachment 354791 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 354791 [details]
Patch

Clearing flags on attachment: 354791

Committed r238169: <https://trac.webkit.org/changeset/238169>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46059298>