Bug 191526 – [WebAuthN] Store necessary authenticator info into HID authenticators

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jiewen Tan]

Store necessary authenticator info into HID authenticators.

[Jiewen Tan]

Created attachment 354784 [details]
Patch

[Jiewen Tan]

Comment on attachment 354784 [details]
Patch

I guess I don't need any review for this one. I will land an unreviewed patch on my own.

[Chris Dumez]

Comment on attachment 354784 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354784&action=review

> Source/WebKit/ChangeLog:8
> +        Somehow this is fixed by r238166. Some very minor improvment over it.

typo: improvment

"Somehow"? You don't know how? I personally find this changelog confusing.

[Jiewen Tan]

(In reply to Chris Dumez from comment #3)
> Comment on attachment 354784 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=354784&action=review
> 
> > Source/WebKit/ChangeLog:8
> > +        Somehow this is fixed by r238166. Some very minor improvment over it.
> 
> typo: improvment
> 
> "Somehow"? You don't know how? I personally find this changelog confusing.

I thought I was working on a branch for this change, and I didn't. Therefore I actually made this change in:
Committed r238166: <https://trac.webkit.org/changeset/238166>.

The change is actually simple as well. Which I just move the AuthenticatorGetInfoResponse to the CtapHidAuthenticator after we have the response. And use the userVerificationAvailability info when issuing requests to authenticators in CtapHidAuthenticator.

[Jiewen Tan]

Committed r238247: <https://trac.webkit.org/changeset/238247>

[Radar WebKit Bug Importer]

<rdar://problem/46106274>

[Alex Christensen]

Comment on attachment 354784 [details]
Patch

This has been requesting review for more than one year.  If this is still needed, please rebase and re-request review.