Bug 191522 - [WebAuthN] PublicKeyCredentialCreationOptions::AuthenticatorSelectionCriteria::AuthenticatorAttachment should be optional
Summary: [WebAuthN] PublicKeyCredentialCreationOptions::AuthenticatorSelectionCriteria...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 181943
  Show dependency tree / graph
 
Reported: 2018-11-11 17:56 PST by Jiewen Tan
Modified: 2018-11-15 12:29 PST (History)
7 users (show)

See Also:

Attachments
Patch (3.97 KB, patch)
2018-11-14 00:37 PST, Jiewen Tan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2018-11-11 17:56:29 PST 
PublicKeyCredentialCreationOptions::AuthenticatorSelectionCriteria::AuthenticatorAttachment should be optional.
Comment 1 Jiewen Tan 2018-11-14 00:37:58 PST 
Created attachment 354777 [details]
Patch
Comment 2 Alex Christensen 2018-11-14 06:10:36 PST 
Comment on attachment 354777 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354777&action=review

> Source/WebCore/ChangeLog:11
> +        Covered by existing tests.

Is there an observable change in behavior from this change?
Comment 3 Brent Fulgham 2018-11-14 08:14:09 PST 
Comment on attachment 354777 [details]
Patch

Looks good. I assume there's no WPT for this, or you would have unskipped it.
Comment 4 Jiewen Tan 2018-11-15 12:02:01 PST 
Comment on attachment 354777 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354777&action=review

Thanks Brent for r+ this patch.

>> Source/WebCore/ChangeLog:11
>> +        Covered by existing tests.
> 
> Is there an observable change in behavior from this change?

Things are a little bit tricky here. There is currently no way of testing the wrong(before) behavior as we only support one kind of authenticators in macOS currently. That means we get the same response if authenticatorAttachment = std::nullopt or CrossPlatform.
Comment 5 WebKit Commit Bot 2018-11-15 12:28:17 PST 
Comment on attachment 354777 [details]
Patch

Clearing flags on attachment: 354777

Committed r238240: <https://trac.webkit.org/changeset/238240>
Comment 6 WebKit Commit Bot 2018-11-15 12:28:19 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-11-15 12:29:35 PST 
<rdar://problem/46104073>