RESOLVED FIXED 191515
[css-grid] Import additional grid layout tests and update TestExpectations 
https://bugs.webkit.org/show_bug.cgi?id=191515
Summary [css-grid] Import additional grid layout tests and update TestExpectations
Javier Fernandez
Reported 2018-11-11 15:31:27 PST
Adding new layout tests for code already landed in trunk but not properly covered by enough test cases. Additionally, we should update the TestExpectations with the proper bugs that cause such expected failures.
Attachments
Patch (311.72 KB, patch)
2018-11-11 15:34 PST, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-sierra (2.47 MB, application/zip)
2018-11-11 16:39 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews105 for mac-sierra-wk2 (2.92 MB, application/zip)
2018-11-11 16:48 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.42 MB, application/zip)
2018-11-11 17:23 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews116 for mac-sierra (3.35 MB, application/zip)
2018-11-11 17:34 PST, EWS Watchlist 		no flags
Details
Patch (306.66 KB, patch)
2018-11-12 04:24 PST, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Javier Fernandez
Comment 1 2018-11-11 15:34:58 PST
Created attachment 354511 [details] Patch
EWS Watchlist
Comment 2 2018-11-11 16:38:59 PST
Comment on attachment 354511 [details] Patch Attachment 354511 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9952220 New failing tests: fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html
EWS Watchlist
Comment 3 2018-11-11 16:39:01 PST
Created attachment 354515 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 4 2018-11-11 16:48:35 PST
Comment on attachment 354511 [details] Patch Attachment 354511 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9952239 New failing tests: fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html
EWS Watchlist
Comment 5 2018-11-11 16:48:37 PST
Created attachment 354516 [details] Archive of layout-test-results from ews105 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 6 2018-11-11 17:23:22 PST
Comment on attachment 354511 [details] Patch Attachment 354511 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9952273 New failing tests: fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html fast/css-grid-layout/preferred-width-computed-after-layout.html
EWS Watchlist
Comment 7 2018-11-11 17:23:24 PST
Created attachment 354519 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 8 2018-11-11 17:34:30 PST
Comment on attachment 354511 [details] Patch Attachment 354511 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9952284 New failing tests: fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html
EWS Watchlist
Comment 9 2018-11-11 17:34:32 PST
Created attachment 354520 [details] Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Javier Fernandez
Comment 10 2018-11-12 04:24:37 PST
Created attachment 354545 [details] Patch
Dean Jackson
Comment 11 2018-11-12 10:00:17 PST
Comment on attachment 354545 [details] Patch rs=me
WebKit Commit Bot
Comment 12 2018-11-12 13:25:15 PST
Comment on attachment 354545 [details] Patch Clearing flags on attachment: 354545 Committed r238105: <https://trac.webkit.org/changeset/238105>
WebKit Commit Bot
Comment 13 2018-11-12 13:25:17 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 14 2018-11-12 13:26:27 PST
<rdar://problem/46001156>
Note You need to log in before you can comment on or make changes to this bug.