Web Inspector: Styles: Pressing Tab or Enter should start editing focused property

[Nikita Vasilyev]

When one or more properties are selected, pressing Tab or Enter key should start editing the first selected property.

Disabled (commented out) properties cannot be edited, so when the first selected property is disabled find the next enabled property and edit it instead.

[Radar WebKit Bug Importer]

<rdar://problem/45970897>

[Nikita Vasilyev]

Created attachment 354486 [details]
Patch

[Nikita Vasilyev]

Created attachment 354487 [details]
[animated GIF] With patch applied

[Devin Rousso]

Comment on attachment 354486 [details]
Patch

I would expect it to edit the selected property (e.g. the one with the left "selection" border), not the first property.  Other than that, looks good.

[Nikita Vasilyev]

Created attachment 354529 [details]
Patch

[Devin Rousso]

Comment on attachment 354529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354529&action=review

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:515
> +            if (property && property.enabled) {

We could probably be a little "smart" here and try to find the first property after (or before if there are none after) that is `enabled`.

[WebKit Commit Bot]

Comment on attachment 354529 [details]
Patch

Clearing flags on attachment: 354529

Committed r238096: <https://trac.webkit.org/changeset/238096>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Nikita Vasilyev]

*** Bug 191135 has been marked as a duplicate of this bug. ***