Bug 191509 - [LFC][IFC] Construct dedicated runs when the inline element requires it.
Summary: [LFC][IFC] Construct dedicated runs when the inline element requires it.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-10 17:36 PST by zalan
Modified: 2018-11-12 08:21 PST (History)
5 users (show)

See Also:


Attachments
Patch (16.48 KB, patch)
2018-11-10 18:10 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (16.48 KB, patch)
2018-11-10 20:50 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (16.86 KB, patch)
2018-11-11 21:50 PST, zalan
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-11-10 17:36:34 PST
When a run overlaps multiple inline elements like this:
<span>normal text content</span><span style="position: relative; left: 10px;">but this one needs dedicated run</span><span>end of text</span>
The above content generates one long run <normal text contentbut this one needs dedicated runend of text>
However the middle run needs to be moved independently from the rest of the content, hence it needs a dedicated inline run.
Comment 1 zalan 2018-11-10 18:10:23 PST
Created attachment 354488 [details]
Patch
Comment 2 zalan 2018-11-10 20:50:58 PST
Created attachment 354494 [details]
Patch
Comment 3 zalan 2018-11-11 21:50:18 PST
Created attachment 354532 [details]
Patch
Comment 4 zalan 2018-11-11 21:51:14 PST
This is not supposed to be too common, but could improve if it ends up being in a hot codepath.
Comment 5 Antti Koivisto 2018-11-12 07:48:41 PST
Comment on attachment 354532 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354532&action=review

> Source/WebCore/ChangeLog:10
> +        <span>normal text content</span><span style="position: relative; left: 10px;">but this one needs a dedicated run</span><span>end of text</span>

No test?
Comment 6 zalan 2018-11-12 08:18:16 PST
Committed r238087: <https://trac.webkit.org/changeset/238087>
Comment 7 Radar WebKit Bug Importer 2018-11-12 08:19:25 PST
<rdar://problem/45990074>
Comment 8 zalan 2018-11-12 08:21:07 PST
(In reply to Antti Koivisto from comment #5)
> Comment on attachment 354532 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=354532&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        <span>normal text content</span><span style="position: relative; left: 10px;">but this one needs a dedicated run</span><span>end of text</span>
> 
> No test?
The positioning part is not done yet. This patch was actually in preparation for that (have to split the runs in order to move them independently)