Bug 191505 - Require <iframe allow="display"> for an iframe to use getDisplayMedia
Summary: Require <iframe allow="display"> for an iframe to use getDisplayMedia
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-10 10:52 PST by Eric Carlson
Modified: 2018-11-12 09:19 PST (History)
6 users (show)

See Also:

Attachments
Patch (15.37 KB, patch)
2018-11-10 10:59 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (20.30 KB, patch)
2018-11-10 11:56 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.02 MB, application/zip)
2018-11-10 13:13 PST, EWS Watchlist 		no flags Details
Patch (20.53 KB, patch)
2018-11-11 16:56 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.93 MB, application/zip)
2018-11-11 18:08 PST, EWS Watchlist 		no flags Details
Patch (20.95 KB, patch)
2018-11-12 06:25 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.03 MB, application/zip)
2018-11-12 07:16 PST, EWS Watchlist 		no flags Details
Patch (21.60 KB, patch)
2018-11-12 07:55 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2018-11-10 10:52:29 PST 
'display' was recently added to the permissions spec for screen capture (https://github.com/w3c/permissions/pull/184). Require <iframe allow="display"> for an iframe to use getDisplayMedia.
Comment 1 Radar WebKit Bug Importer 2018-11-10 10:52:54 PST 
<rdar://problem/45968811>
Comment 2 Eric Carlson 2018-11-10 10:59:52 PST 
Created attachment 354463 [details]
Patch
Comment 3 Eric Carlson 2018-11-10 11:56:07 PST 
Created attachment 354468 [details]
Patch
Comment 4 EWS Watchlist 2018-11-10 13:13:18 PST 
Comment on attachment 354468 [details]
Patch

Attachment 354468 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9941440

New failing tests:
http/tests/media/media-stream/get-display-media-iframe-allow-attribute.html
Comment 5 EWS Watchlist 2018-11-10 13:13:20 PST 
Created attachment 354473 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 Eric Carlson 2018-11-11 16:56:08 PST 
Created attachment 354517 [details]
Patch
Comment 7 EWS Watchlist 2018-11-11 18:08:52 PST 
Comment on attachment 354517 [details]
Patch

Attachment 354517 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9952769

New failing tests:
http/tests/media/media-stream/get-display-media-iframe-allow-attribute.html
Comment 8 EWS Watchlist 2018-11-11 18:08:54 PST 
Created attachment 354521 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 9 Eric Carlson 2018-11-12 06:25:24 PST 
Created attachment 354554 [details]
Patch
Comment 10 EWS Watchlist 2018-11-12 07:16:04 PST 
Comment on attachment 354554 [details]
Patch

Attachment 354554 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9958042

New failing tests:
http/tests/media/media-stream/get-display-media-iframe-allow-attribute.html
Comment 11 EWS Watchlist 2018-11-12 07:16:06 PST 
Created attachment 354557 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 12 Eric Carlson 2018-11-12 07:55:23 PST 
Created attachment 354558 [details]
Patch
Comment 13 WebKit Commit Bot 2018-11-12 09:18:58 PST 
Comment on attachment 354558 [details]
Patch

Clearing flags on attachment: 354558

Committed r238091: <https://trac.webkit.org/changeset/238091>
Comment 14 WebKit Commit Bot 2018-11-12 09:19:00 PST 
All reviewed patches have been landed.  Closing bug.