Bug 191499 – Allow WebKit clients to specify a minimum effective width for layout.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Yongjun Zhang]

If we ignore the meta viewport (_shouldIgnoreMetaViewport is true), the default layout width will be device width in full screen. For clients that wish to lay out the content with a different width value, we would need to add a way to specify the effective width.

[Yongjun Zhang]

<rdar://problem/45362678>

[Yongjun Zhang]

Created attachment 354471 [details]
Patch.

[Yongjun Zhang]

Created attachment 354480 [details]
Fix mac build and layout tests.

[Wenson Hsieh]

Comment on attachment 354480 [details]
Fix mac build and layout tests.

View in context: https://bugs.webkit.org/attachment.cgi?id=354480&action=review

> Source/WebCore/page/ViewportConfiguration.h:140
>      }

We should probably update forceAlwaysUserScalableMinimumScale() and forceAlwaysUserScalableMaximumScale() to use the effective layout scale factor too.

> Source/WebKit/UIProcess/WebPageProxy.h:592
> +    void setViewportConfigurationViewLayoutSize(const WebCore::FloatSize&, double scaleFactor, double effectiveWidth);

The variable name here (and in other places when plumbing from WKWebView to ViewportConfiguration) should probably be minimumEffectiveDeviceWidth, rather than effectiveWidth.

[EWS Watchlist]

Comment on attachment 354480 [details]
Fix mac build and layout tests.

Attachment 354480 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9944175

New failing tests:
fast/viewport/ios/minimum-scale-after-changing-view-scale.html

[EWS Watchlist]

Created attachment 354492 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Yongjun Zhang]

Created attachment 354614 [details]
Address review comments.

[Wenson Hsieh]

Comment on attachment 354614 [details]
Address review comments.

View in context: https://bugs.webkit.org/attachment.cgi?id=354614&action=review

> LayoutTests/ChangeLog:13
> +

Nit - extra newline here.

[WebKit Commit Bot]

Comment on attachment 354614 [details]
Address review comments.

Clearing flags on attachment: 354614

Committed r238623: <https://trac.webkit.org/changeset/238623>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.