RESOLVED FIXED 191488
Suspended page persists even after back/forward list item is gone 
https://bugs.webkit.org/show_bug.cgi?id=191488
Summary Suspended page persists even after back/forward list item is gone
Chris Dumez
Reported 2018-11-09 14:55:38 PST
Suspended page persists even after back/forward list item is gone.
Attachments
Patch (11.00 KB, patch)
2018-11-09 15:02 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (15.22 KB, patch)
2018-11-09 15:47 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-11-09 14:55:54 PST
<rdar://problem/45953006>
Chris Dumez
Comment 2 2018-11-09 15:02:06 PST
Created attachment 354393 [details] Patch
Geoffrey Garen
Comment 3 2018-11-09 15:08:49 PST
Comment on attachment 354393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354393&action=review > Source/WebKit/Shared/WebBackForwardListItem.cpp:129 > +void WebBackForwardListItem::suspendedPageIsNoLongerNeeded() I would call this removeSuspendedPageFromProcessPool. > Source/WebKit/UIProcess/WebProcessPool.cpp:2273 > +void WebProcessPool::removeSuspendedPageProxy(SuspendedPageProxy& suspendedPage) I would call this removeSuspendedPage.
Geoffrey Garen
Comment 4 2018-11-09 15:09:14 PST
Comment on attachment 354393 [details] Patch r=me
Chris Dumez
Comment 5 2018-11-09 15:47:35 PST
Created attachment 354399 [details] Patch
WebKit Commit Bot
Comment 6 2018-11-09 16:24:16 PST
Comment on attachment 354399 [details] Patch Clearing flags on attachment: 354399 Committed r238061: <https://trac.webkit.org/changeset/238061>
WebKit Commit Bot
Comment 7 2018-11-09 16:24:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.