Bug 191488 - Suspended page persists even after back/forward list item is gone
Summary: Suspended page persists even after back/forward list item is gone
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-09 14:55 PST by Chris Dumez
Modified: 2018-11-09 16:24 PST (History)
3 users (show)

See Also:

Attachments
Patch (11.00 KB, patch)
2018-11-09 15:02 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (15.22 KB, patch)
2018-11-09 15:47 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-11-09 14:55:38 PST 
Suspended page persists even after back/forward list item is gone.
Comment 1 Chris Dumez 2018-11-09 14:55:54 PST 
<rdar://problem/45953006>
Comment 2 Chris Dumez 2018-11-09 15:02:06 PST 
Created attachment 354393 [details]
Patch
Comment 3 Geoffrey Garen 2018-11-09 15:08:49 PST 
Comment on attachment 354393 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354393&action=review

> Source/WebKit/Shared/WebBackForwardListItem.cpp:129
> +void WebBackForwardListItem::suspendedPageIsNoLongerNeeded()

I would call this removeSuspendedPageFromProcessPool.

> Source/WebKit/UIProcess/WebProcessPool.cpp:2273
> +void WebProcessPool::removeSuspendedPageProxy(SuspendedPageProxy& suspendedPage)

I would call this removeSuspendedPage.
Comment 4 Geoffrey Garen 2018-11-09 15:09:14 PST 
Comment on attachment 354393 [details]
Patch

r=me
Comment 5 Chris Dumez 2018-11-09 15:47:35 PST 
Created attachment 354399 [details]
Patch
Comment 6 WebKit Commit Bot 2018-11-09 16:24:16 PST 
Comment on attachment 354399 [details]
Patch

Clearing flags on attachment: 354399

Committed r238061: <https://trac.webkit.org/changeset/238061>
Comment 7 WebKit Commit Bot 2018-11-09 16:24:17 PST 
All reviewed patches have been landed.  Closing bug.