Tapping the shift key on the software keyboard should dispatch DOM key events. Double tapping the shift key on the software keyboard to toggle caps locks should show the caps locks indicator if the currently focused element is a password field.
You can observe this issue by performing the following: 1. Visit <https://unixpapa.com/js/testkey.html>. 2. Check the modifiers checkbox. 3. Focus the text field. 4. Tap the shift key on the software keyboard. Nothing happens. But we should have seen a keydown and keyup event for the shift key. Similarly, nothing happens if you enable caps lock or disable caps lock by double tapping the shift key.
<rdar://problem/45949246>
Created attachment 357627 [details] Patch It is not possible to write a test for this change with our current infrastructure without mocking more of the software keyboard or performing user interface testing. I am open to ideas.
Comment on attachment 357627 [details] Patch Attachment 357627 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10466513 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html
Created attachment 357644 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 357644 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 This EWS failure is not related to this patch. I've seen it happen on other patches as well.
Created attachment 358396 [details] Patch
Comment on attachment 358396 [details] Patch Attachment 358396 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10635430 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall.https.html
Created attachment 358418 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 358396 [details] Patch Clearing flags on attachment: 358396 Committed r240288: <https://trac.webkit.org/changeset/240288>
All reviewed patches have been landed. Closing bug.