LLInt VectorSizeOffset should be based on PtrSize
Created attachment 354337 [details] Patch
Comment on attachment 354337 [details] Patch Attachment 354337 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9923489 Number of test failures exceeded the failure limit.
Created attachment 354339 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 354337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354337&action=review > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:524 > +const VectorSizeOffset = PtrSize * 2 I think the size offset is `PtrSize + 4`, 4 for `unsigned` capacity. How about using Vector<XXX>::m_size instead?
Comment on attachment 354337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354337&action=review >> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:524 >> +const VectorSizeOffset = PtrSize * 2 > > I think the size offset is `PtrSize + 4`, 4 for `unsigned` capacity. > How about using Vector<XXX>::m_size instead? BTW, VectorBufferOffset is wrongly used in some places of LLInt. It is also used for RefCountedArray (m_argumentValueProfiles). I think we should use RefCountedArray<XXX>::m_data instead.
Comment on attachment 354337 [details] Patch Attachment 354337 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9923694 Number of test failures exceeded the failure limit.
Created attachment 354342 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 354337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354337&action=review >>> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:524 >>> +const VectorSizeOffset = PtrSize * 2 >> >> I think the size offset is `PtrSize + 4`, 4 for `unsigned` capacity. >> How about using Vector<XXX>::m_size instead? > > BTW, VectorBufferOffset is wrongly used in some places of LLInt. It is also used for RefCountedArray (m_argumentValueProfiles). > I think we should use RefCountedArray<XXX>::m_data instead. Ah, whoops. I don't think the LLInt supports using <> in the object offsets syntax, though.
Comment on attachment 354337 [details] Patch Attachment 354337 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9923755 Number of test failures exceeded the failure limit.
Created attachment 354343 [details] Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 354337 [details] Patch Attachment 354337 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9923747 Number of test failures exceeded the failure limit.
Created attachment 354344 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 354337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354337&action=review >>>> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:524 >>>> +const VectorSizeOffset = PtrSize * 2 >>> >>> I think the size offset is `PtrSize + 4`, 4 for `unsigned` capacity. >>> How about using Vector<XXX>::m_size instead? >> >> BTW, VectorBufferOffset is wrongly used in some places of LLInt. It is also used for RefCountedArray (m_argumentValueProfiles). >> I think we should use RefCountedArray<XXX>::m_data instead. > > Ah, whoops. I don't think the LLInt supports using <> in the object offsets syntax, though. How about `const VectorSizeOffset = SimpleJumpTable::branchOffsets::m_size`?
Comment on attachment 354337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354337&action=review >>>>> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:524 >>>>> +const VectorSizeOffset = PtrSize * 2 >>>> >>>> I think the size offset is `PtrSize + 4`, 4 for `unsigned` capacity. >>>> How about using Vector<XXX>::m_size instead? >>> >>> BTW, VectorBufferOffset is wrongly used in some places of LLInt. It is also used for RefCountedArray (m_argumentValueProfiles). >>> I think we should use RefCountedArray<XXX>::m_data instead. >> >> Ah, whoops. I don't think the LLInt supports using <> in the object offsets syntax, though. > > How about `const VectorSizeOffset = SimpleJumpTable::branchOffsets::m_size`? Ohh! Clever! I think I'd need to make a typedef for branchOffsets but I like the idea!
Created attachment 354346 [details] Patch
Comment on attachment 354346 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354346&action=review r=me, nice! > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:523 > +const VectorSizeOffset = Vector::m_size Nice!
Committed r238031: <https://trac.webkit.org/changeset/238031>
<rdar://problem/45944924>