Bug 191465 - [css-grid] Dynamically setting "position: absolute" in a grid item doesn't trigger a relayout of that element
Summary: [css-grid] Dynamically setting "position: absolute" in a grid item doesn't tr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-09 05:05 PST by Javier Fernandez
Modified: 2020-06-03 00:32 PDT (History)
15 users (show)

See Also:

Attachments
Test case to reproduce the issue (500 bytes, text/html)
2018-11-09 05:05 PST, Javier Fernandez 		no flags Details
Patch (4.16 KB, patch)
2018-11-09 05:21 PST, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.45 MB, application/zip)
2018-11-09 06:24 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.99 MB, application/zip)
2018-11-09 06:34 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews113 for mac-sierra (3.38 MB, application/zip)
2018-11-09 07:16 PST, EWS Watchlist 		no flags Details
Patch rebased (4.29 KB, patch)
2020-06-01 14:07 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Rebased again (4.11 KB, patch)
2020-06-02 07:34 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2018-11-09 05:05:13 PST 
Created attachment 354329 [details]
Test case to reproduce the issue

Check the attached example, you shouldn't see red as the item gets absolute positioned and should take the whole size of the grid.

Note that in the example, when "item" is marked as absolutely positioned, its containing block is "wrapper" and not the grid container.
For some reason we're not triggering a new layout of the "item" in this situation.
Comment 1 Javier Fernandez 2018-11-09 05:21:22 PST 
Created attachment 354331 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2018-11-09 06:07:57 PST 
Comment on attachment 354331 [details]
Patch

r=me
Comment 3 EWS Watchlist 2018-11-09 06:24:02 PST 
Comment on attachment 354331 [details]
Patch

Attachment 354331 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9922961

New failing tests:
imported/w3c/web-platform-tests/css/css-grid/abspos/grid-item-absolute-positioning-dynamic-001.html
imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-changing-containing-block-001.html
Comment 4 EWS Watchlist 2018-11-09 06:24:04 PST 
Created attachment 354333 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-11-09 06:34:15 PST 
Comment on attachment 354331 [details]
Patch

Attachment 354331 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9922975

New failing tests:
imported/w3c/web-platform-tests/css/css-grid/abspos/grid-item-absolute-positioning-dynamic-001.html
imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-changing-containing-block-001.html
Comment 6 EWS Watchlist 2018-11-09 06:34:17 PST 
Created attachment 354335 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 EWS Watchlist 2018-11-09 07:16:56 PST 
Comment on attachment 354331 [details]
Patch

Attachment 354331 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9923108

New failing tests:
imported/w3c/web-platform-tests/css/css-grid/abspos/grid-item-absolute-positioning-dynamic-001.html
imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-changing-containing-block-001.html
Comment 8 EWS Watchlist 2018-11-09 07:16:58 PST 
Created attachment 354340 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 9 Manuel Rego Casasnovas 2019-11-28 05:09:42 PST 
Mmmm, dunno why this patch never landed... we might want to review it again at some poing.
Comment 10 Oriol Brufau 2020-06-01 06:39:06 PDT 
The patch seems fine, just needs a rebase.
Comment 11 Javier Fernandez 2020-06-01 14:07:36 PDT 
Created attachment 400757 [details]
Patch rebased
Comment 12 Manuel Rego Casasnovas 2020-06-02 04:40:55 PDT 
(In reply to Javier Fernandez from comment #11)
> Created attachment 400757 [details]
> Patch rebased

It seems the patch is not rebased yet.
Comment 13 Javier Fernandez 2020-06-02 07:34:43 PDT 
Created attachment 400820 [details]
Rebased again
Comment 14 Manuel Rego Casasnovas 2020-06-02 08:58:27 PDT 
Comment on attachment 400820 [details]
Rebased again

r=me
Comment 15 EWS 2020-06-03 00:31:33 PDT 
Committed r262481: <https://trac.webkit.org/changeset/262481>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400820 [details].
Comment 16 Radar WebKit Bug Importer 2020-06-03 00:32:21 PDT 
<rdar://problem/63913363>