Bug 191455 - WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Summary: WebHistory.h: warning: 'QueryInterface' overrides a member function but is no...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-08 21:17 PST by Fujii Hironori
Modified: 2018-11-09 08:44 PST (History)
6 users (show)

See Also:

Attachments
Patch (4.34 KB, patch)
2018-11-08 21:23 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-11-08 21:17:33 PST 
WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Clang-cl reports following compilation warnings while building WinCairo port:

> [5754/6223] Building CXX object Source\WebKitLegacy\CMakeFiles\WebKitLegacy.dir\win\WebHistory.cpp.obj
> In file included from ..\..\Source\WebKitLegacy\win\WebHistory.cpp:27:
> ..\..\Source\WebKitLegacy\win/WebHistory.h(54,39):  warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
>                                       ^
> C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um\unknwnbase.h(113,47):  note: overridden virtual function is here
>             virtual HRESULT STDMETHODCALLTYPE QueryInterface( 
>                                               ^
> In file included from ..\..\Source\WebKitLegacy\win\WebHistory.cpp:27:
> ..\..\Source\WebKitLegacy\win/WebHistory.h(55,37):  warning: 'AddRef' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>     virtual ULONG STDMETHODCALLTYPE AddRef();
>                                     ^
> C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um\unknwnbase.h(117,45):  note: overridden virtual function is here
>             virtual ULONG STDMETHODCALLTYPE AddRef( void) = 0;
>                                             ^
> In file included from ..\..\Source\WebKitLegacy\win\WebHistory.cpp:27:
> ..\..\Source\WebKitLegacy\win/WebHistory.h(56,37):  warning: 'Release' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>     virtual ULONG STDMETHODCALLTYPE Release();
>                                     ^
> C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um\unknwnbase.h(119,45):  note: overridden virtual function is here
>             virtual ULONG STDMETHODCALLTYPE Release( void) = 0;
>                                             ^
Comment 1 Fujii Hironori 2018-11-08 21:23:12 PST 
Created attachment 354312 [details]
Patch
Comment 2 Don Olmstead 2018-11-08 21:26:47 PST 
LGTM
Comment 3 Brent Fulgham 2018-11-09 08:18:09 PST 
Comment on attachment 354312 [details]
Patch

Nice! It's great to see more of this code getting good attention. Thank you!
Comment 4 WebKit Commit Bot 2018-11-09 08:42:59 PST 
Comment on attachment 354312 [details]
Patch

Clearing flags on attachment: 354312

Committed r238032: <https://trac.webkit.org/changeset/238032>
Comment 5 WebKit Commit Bot 2018-11-09 08:43:01 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-11-09 08:44:09 PST 
<rdar://problem/45944979>