Bug 191455 – WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Fujii Hironori]

WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Clang-cl reports following compilation warnings while building WinCairo port:

> [5754/6223] Building CXX object Source\WebKitLegacy\CMakeFiles\WebKitLegacy.dir\win\WebHistory.cpp.obj
> In file included from ..\..\Source\WebKitLegacy\win\WebHistory.cpp:27:
> ..\..\Source\WebKitLegacy\win/WebHistory.h(54,39):  warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
>                                       ^
> C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um\unknwnbase.h(113,47):  note: overridden virtual function is here
>             virtual HRESULT STDMETHODCALLTYPE QueryInterface( 
>                                               ^
> In file included from ..\..\Source\WebKitLegacy\win\WebHistory.cpp:27:
> ..\..\Source\WebKitLegacy\win/WebHistory.h(55,37):  warning: 'AddRef' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>     virtual ULONG STDMETHODCALLTYPE AddRef();
>                                     ^
> C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um\unknwnbase.h(117,45):  note: overridden virtual function is here
>             virtual ULONG STDMETHODCALLTYPE AddRef( void) = 0;
>                                             ^
> In file included from ..\..\Source\WebKitLegacy\win\WebHistory.cpp:27:
> ..\..\Source\WebKitLegacy\win/WebHistory.h(56,37):  warning: 'Release' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>     virtual ULONG STDMETHODCALLTYPE Release();
>                                     ^
> C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um\unknwnbase.h(119,45):  note: overridden virtual function is here
>             virtual ULONG STDMETHODCALLTYPE Release( void) = 0;
>                                             ^

[Fujii Hironori]

Created attachment 354312 [details]
Patch

[Don Olmstead]

LGTM

[Brent Fulgham]

Comment on attachment 354312 [details]
Patch

Nice! It's great to see more of this code getting good attention. Thank you!

[WebKit Commit Bot]

Comment on attachment 354312 [details]
Patch

Clearing flags on attachment: 354312

Committed r238032: <https://trac.webkit.org/changeset/238032>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45944979>