Bug 191453 – MediaPlayerPrivateMediaFoundation.h: warning: 'GetService' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Fujii Hironori]

Clang-cl reports following compilation warnings while building WinCairo port:

> [5097/6223] Building CXX object Source\WebCore\CMakeFiles\WebCore.dir\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp.obj
> In file included from ..\..\Source\WebCore\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp:28:
> ..\..\Source\WebCore\platform\graphics\win/MediaPlayerPrivateMediaFoundation.h(361,43):  warning: 'GetService' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>         virtual HRESULT STDMETHODCALLTYPE GetService(REFGUID guidService, REFIID riid, LPVOID *ppvObject);
>                                           ^
> C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um/mfidl.h(4891,43):  note: overridden virtual function is here
>         virtual HRESULT STDMETHODCALLTYPE GetService( 
>                                           ^
> In file included from ..\..\Source\WebCore\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp:28:
> ..\..\Source\WebCore\platform\graphics\win/MediaPlayerPrivateMediaFoundation.h(364,43):  warning: 'ActivateObject' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>         virtual HRESULT STDMETHODCALLTYPE ActivateObject(REFIID riid, void **ppv);
>                                           ^
> C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um/mfobjects.h(5264,43):  note: overridden virtual function is here
>         virtual HRESULT STDMETHODCALLTYPE ActivateObject( 
>                                           ^
> In file included from ..\..\Source\WebCore\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp:28:
> ..\..\Source\WebCore\platform\graphics\win/MediaPlayerPrivateMediaFoundation.h(365,43):  warning: 'DetachObject' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>         virtual HRESULT STDMETHODCALLTYPE DetachObject();
>                                           ^
> C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um/mfobjects.h(5270,43):  note: overridden virtual function is here
>         virtual HRESULT STDMETHODCALLTYPE DetachObject( void) = 0;
>                                           ^
> In file included from ..\..\Source\WebCore\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp:28:
> ..\..\Source\WebCore\platform\graphics\win/MediaPlayerPrivateMediaFoundation.h(366,43):  warning: 'ShutdownObject' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>         virtual HRESULT STDMETHODCALLTYPE ShutdownObject();
>                                           ^
> C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um/mfobjects.h(5268,43):  note: overridden virtual function is here
>         virtual HRESULT STDMETHODCALLTYPE ShutdownObject( void) = 0;
>                                           ^

[Fujii Hironori]

Created attachment 354310 [details]
Patch

[Don Olmstead]

LGTM

It would probably save you some time to look into running clang tidy now that you have clang cl working. There’s a modernize lint https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html and most of the modernize lints have an associated fix.

[Per Arne Vollan]

Comment on attachment 354310 [details]
Patch

r=me.

[WebKit Commit Bot]

Comment on attachment 354310 [details]
Patch

Clearing flags on attachment: 354310

Committed r238040: <https://trac.webkit.org/changeset/238040>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45947797>