Bug 191451 – Extensions3DOpenGLES.h: warning: 'blitFramebuffer' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Fujii Hironori]

Clang-cl 7.0 reports following compilation warnings while building WebKit WinCairo port.

> [4903/6223] Building CXX object Source\WebCore\CMakeFiles\WebCore.dir\platform\graphics\opengl\Extensions3DOpenGLES.cpp.obj
> In file included from ..\..\Source\WebCore\platform\graphics\opengl\Extensions3DOpenGLES.cpp:31:
> ..\..\Source\WebCore\platform\graphics\opengl/Extensions3DOpenGLES.h(80,18):  warning: 'blitFramebuffer' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>     virtual void blitFramebuffer(long srcX0, long srcY0, long srcX1, long srcY1, long dstX0, long dstY0, long dstX1, long dstY1, unsigned long mask, unsigned long filter);
>                  ^
> ..\..\Source\WebCore\platform\graphics\Extensions3D.h(254,18):  note: overridden virtual function is here
>     virtual void blitFramebuffer(long srcX0, long srcY0, long srcX1, long srcY1, long dstX0, long dstY0, long dstX1, long dstY1, unsigned long mask, unsigned long filter) = 0;
>                  ^
> In file included from ..\..\Source\WebCore\platform\graphics\opengl\Extensions3DOpenGLES.cpp:31:
> ..\..\Source\WebCore\platform\graphics\opengl/Extensions3DOpenGLES.h(81,18):  warning: 'renderbufferStorageMultisample' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>     virtual void renderbufferStorageMultisample(unsigned long target, unsigned long samples, unsigned long internalformat, unsigned long width, unsigned long height);
>                  ^
> ..\..\Source\WebCore\platform\graphics\Extensions3D.h(257,18):  note: overridden virtual function is here
>     virtual void renderbufferStorageMultisample(unsigned long target, unsigned long samples, unsigned long internalformat, unsigned long width, unsigned long height) = 0;
>                  ^
> In file included from ..\..\Source\WebCore\platform\graphics\opengl\Extensions3DOpenGLES.cpp:31:
> ..\..\Source\WebCore\platform\graphics\opengl/Extensions3DOpenGLES.h(82,18):  warning: 'insertEventMarkerEXT' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>     virtual void insertEventMarkerEXT(const String&);
>                  ^
> ..\..\Source\WebCore\platform\graphics\Extensions3D.h(274,18):  note: overridden virtual function is here
>     virtual void insertEventMarkerEXT(const String&) = 0;
>                  ^
> In file included from ..\..\Source\WebCore\platform\graphics\opengl\Extensions3DOpenGLES.cpp:31:
> ..\..\Source\WebCore\platform\graphics\opengl/Extensions3DOpenGLES.h(83,18):  warning: 'pushGroupMarkerEXT' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>     virtual void pushGroupMarkerEXT(const String&);
>                  ^
> ..\..\Source\WebCore\platform\graphics\Extensions3D.h(275,18):  note: overridden virtual function is here
>     virtual void pushGroupMarkerEXT(const String&) = 0;
>                  ^
> In file included from ..\..\Source\WebCore\platform\graphics\opengl\Extensions3DOpenGLES.cpp:31:
> ..\..\Source\WebCore\platform\graphics\opengl/Extensions3DOpenGLES.h(84,18):  warning: 'popGroupMarkerEXT' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>     virtual void popGroupMarkerEXT(void);
>                  ^
> ..\..\Source\WebCore\platform\graphics\Extensions3D.h(276,18):  note: overridden virtual function is here
>     virtual void popGroupMarkerEXT(void) = 0;
>                  ^
> In file included from ..\..\Source\WebCore\platform\graphics\opengl\Extensions3DOpenGLES.cpp:31:

[Fujii Hironori]

Created attachment 354305 [details]
Patch

[Don Olmstead]

LGTM!

[WebKit Commit Bot]

Comment on attachment 354305 [details]
Patch

Clearing flags on attachment: 354305

Committed r238044: <https://trac.webkit.org/changeset/238044>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45948603>