Bug 191449 - Make use of _UIRemoteView instead of CALayerHost if possible for WKRemoteView
Summary: Make use of _UIRemoteView instead of CALayerHost if possible for WKRemoteView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-08 18:11 PST by Tim Horton
Modified: 2018-11-09 10:59 PST (History)
8 users (show)

See Also:

Attachments
Patch (5.20 KB, patch)
2018-11-08 18:16 PST, Tim Horton 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-11-08 18:11:06 PST 
Make use of _UIRemoteView instead of CALayerHost if possible for WKRemoteView
Comment 1 Tim Horton 2018-11-08 18:16:03 PST 
Created attachment 354299 [details]
Patch
Comment 2 Tim Horton 2018-11-08 18:16:05 PST 
<rdar://problem/45884977>
Comment 3 Eric Carlson 2018-11-09 09:00:11 PST 
Comment on attachment 354299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354299&action=review

> Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:189
> +        std::call_once(initializeCanUseUIRemoteView, [] {
> +            canUseUIRemoteView = [_UIRemoteView instancesRespondToSelector:@selector(initWithFrame:pid:contextID:)];
> +        });

Nit: this indentation is odd, although the style-bot didn't complain and it is usually much more picky than I am.
Comment 4 Tim Horton 2018-11-09 10:55:33 PST 
Comment on attachment 354299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354299&action=review

>> Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:189
>> +        });
> 
> Nit: this indentation is odd, although the style-bot didn't complain and it is usually much more picky than I am.

That is really weird. Also not sure how it happened. Thank you for your review!
Comment 5 Tim Horton 2018-11-09 10:58:56 PST 
https://trac.webkit.org/changeset/238045/webkit