Bug 191448 - Clean up test expectations after r237942
Summary: Clean up test expectations after r237942
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-08 17:19 PST by Ryan Haddad
Modified: 2018-11-08 17:53 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2018-11-08 17:19:18 PST
The following tests are failing on High Sierra WK1 after https://trac.webkit.org/changeset/237942/webkit:

compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint.html
compositing/repaint/iframes/compositing-iframe-scroll-repaint.html
compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint.html

--- /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint-actual.txt
@@ -14,6 +14,8 @@
           (drawsContent 1)
           (repaint rects
             (rect 16.00 16.00 400.00 300.00)
+            (rect 24.00 16.00 100.00 8.00)
+            (rect 16.00 16.00 400.00 300.00)
           )
         )
         (GraphicsLayer

--- /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/compositing/repaint/iframes/compositing-iframe-scroll-repaint-actual.txt
@@ -13,6 +13,7 @@
           (bounds 432.00 332.00)
           (drawsContent 1)
           (repaint rects
+            (rect 16.00 16.00 400.00 300.00)
             (rect 16.00 16.00 400.00 300.00)
           )
           (children 1

--- /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-actual.txt
@@ -13,6 +13,7 @@
           (bounds 432.00 332.00)
           (drawsContent 1)
           (repaint rects
+            (rect 16.00 16.00 400.00 300.00)
             (rect 16.00 16.00 400.00 300.00)
           )
           (children 1
Comment 1 Ryan Haddad 2018-11-08 17:23:18 PST
Additional datapoints after r237942:

This test went from flaky failure -> failure on Mojave
compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint.html
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=compositing%2Frepaint%2Fiframes%2Fcomposited-iframe-with-fixed-background-doc-repaint.html

This test went from flaky failure -> passing on Mojave
compositing/repaint/iframes/compositing-iframe-scroll-repaint.html
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=compositing%2Frepaint%2Fiframes%2Fcompositing-iframe-scroll-repaint.html

This test went from flaky failure -> passing on Mojave
compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint.html
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=compositing%2Frepaint%2Fiframes%2Fcompositing-iframe-with-fixed-background-doc-repaint.html
Comment 2 Simon Fraser (smfr) 2018-11-08 17:34:02 PST
We should add High Sierra-specific results. Some of these repaints are triggered by AppKit, which differs between OS versions.
Comment 3 Ryan Haddad 2018-11-08 17:52:33 PST
https://trac.webkit.org/changeset/238013/webkit
Comment 4 Radar WebKit Bug Importer 2018-11-08 17:53:28 PST
<rdar://problem/45931139>