Bug 191423 – Remove legacy storage tracker database file after r237330

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sihui Liu]

r237330 changed name of the storage tracker database file in WebKitLegacy, but I didn't remove the file with old name before using the new file.

[Sihui Liu]

Created attachment 354245 [details]
Patch

[Geoffrey Garen]

Comment on attachment 354245 [details]
Patch

r=me

[Chris Dumez]

Comment on attachment 354245 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354245&action=review

> Source/WebKitLegacy/Storage/StorageTracker.cpp:84
> +        FileSystem::deleteFile(FileSystem::pathByAppendingComponent(m_storageDirectoryPath, "StorageTracker.db"));

A comment explaining why we do did would have been nice. It does not seem obvious to me.

[WebKit Commit Bot]

Comment on attachment 354245 [details]
Patch

Clearing flags on attachment: 354245

Committed r238036: <https://trac.webkit.org/changeset/238036>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45946046>

[Chris Dumez]

Comment on attachment 354245 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354245&action=review

>> Source/WebKitLegacy/Storage/StorageTracker.cpp:84
>> +        FileSystem::deleteFile(FileSystem::pathByAppendingComponent(m_storageDirectoryPath, "StorageTracker.db"));
> 
> A comment explaining why we do did would have been nice. It does not seem obvious to me.

Also, since the second parameter constructs a String, "StorageTracker.db"_s would be better than "StorageTracker.db".