Bug 191423 - Remove legacy storage tracker database file after r237330
Summary: Remove legacy storage tracker database file after r237330
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-08 09:25 PST by Sihui Liu
Modified: 2018-11-09 09:29 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.50 KB, patch)
2018-11-08 09:39 PST, Sihui Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2018-11-08 09:25:05 PST
r237330 changed name of the storage tracker database file in WebKitLegacy, but I didn't remove the file with old name before using the new file.
Comment 1 Sihui Liu 2018-11-08 09:39:47 PST
Created attachment 354245 [details]
Patch
Comment 2 Geoffrey Garen 2018-11-08 13:36:06 PST
Comment on attachment 354245 [details]
Patch

r=me
Comment 3 Chris Dumez 2018-11-09 09:27:26 PST
Comment on attachment 354245 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354245&action=review

> Source/WebKitLegacy/Storage/StorageTracker.cpp:84
> +        FileSystem::deleteFile(FileSystem::pathByAppendingComponent(m_storageDirectoryPath, "StorageTracker.db"));

A comment explaining why we do did would have been nice. It does not seem obvious to me.
Comment 4 WebKit Commit Bot 2018-11-09 09:27:42 PST
Comment on attachment 354245 [details]
Patch

Clearing flags on attachment: 354245

Committed r238036: <https://trac.webkit.org/changeset/238036>
Comment 5 WebKit Commit Bot 2018-11-09 09:27:44 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-11-09 09:28:20 PST
<rdar://problem/45946046>
Comment 7 Chris Dumez 2018-11-09 09:29:05 PST
Comment on attachment 354245 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354245&action=review

>> Source/WebKitLegacy/Storage/StorageTracker.cpp:84
>> +        FileSystem::deleteFile(FileSystem::pathByAppendingComponent(m_storageDirectoryPath, "StorageTracker.db"));
> 
> A comment explaining why we do did would have been nice. It does not seem obvious to me.

Also, since the second parameter constructs a String, "StorageTracker.db"_s would be better than "StorageTracker.db".