Redundant bindArguments() noticed
resetAndRebindStatement() calls establishStatement() establishStatement() calls createSQLiteStatement() createSQLiteStatement() calls bindArguments() So we don't need to call bindArguments() additionally in resetAndRebindStatement().
Created attachment 354243 [details] Patch
Comment on attachment 354243 [details] Patch Attachment 354243 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9910386 New failing tests: storage/indexeddb/cursor-update-while-iterating.html storage/indexeddb/modern/index-cursor-3.html storage/indexeddb/cursor-continue-validity.html storage/indexeddb/cursor-added-bug.html storage/indexeddb/cursor-update.html storage/indexeddb/cursor-skip-deleted.html imported/w3c/web-platform-tests/IndexedDB/idbcursor_iterating.htm imported/w3c/web-platform-tests/IndexedDB/idbcursor-iterating-update.htm
Created attachment 354247 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 354243 [details] Patch Attachment 354243 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9910671 New failing tests: storage/indexeddb/cursor-update-while-iterating.html storage/indexeddb/modern/index-cursor-3.html storage/indexeddb/cursor-continue-validity.html storage/indexeddb/cursor-added-bug.html storage/indexeddb/cursor-update.html storage/indexeddb/cursor-skip-deleted.html
Created attachment 354252 [details] Archive of layout-test-results from ews203 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews203 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 354243 [details] Patch Attachment 354243 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9910500 New failing tests: storage/indexeddb/cursor-update-while-iterating.html storage/indexeddb/modern/index-cursor-3.html storage/indexeddb/cursor-continue-validity.html imported/w3c/web-platform-tests/IndexedDB/idbcursor-iterating-update.htm storage/indexeddb/cursor-update.html storage/indexeddb/cursor-skip-deleted.html imported/w3c/web-platform-tests/IndexedDB/idbcursor_iterating.htm storage/indexeddb/cursor-added-bug.html
Created attachment 354253 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 354243 [details] Patch Attachment 354243 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9910535 New failing tests: storage/indexeddb/cursor-update-while-iterating.html storage/indexeddb/modern/index-cursor-3.html storage/indexeddb/cursor-continue-validity.html storage/indexeddb/cursor-added-bug.html storage/indexeddb/cursor-skip-deleted.html imported/w3c/web-platform-tests/IndexedDB/idbcursor_iterating.htm imported/w3c/web-platform-tests/IndexedDB/idbcursor-iterating-update.htm
Created attachment 354255 [details] Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 354243 [details] Patch Attachment 354243 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9911617 New failing tests: storage/indexeddb/cursor-update-while-iterating.html storage/indexeddb/modern/index-cursor-3.html storage/indexeddb/cursor-continue-validity.html storage/indexeddb/cursor-added-bug.html storage/indexeddb/cursor-skip-deleted.html imported/w3c/web-platform-tests/IndexedDB/idbcursor_iterating.htm imported/w3c/web-platform-tests/IndexedDB/idbcursor-iterating-update.htm
Created attachment 354262 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 354243 [details] Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.