Bug 191421 - [Flatpak] Refactoring and drive-by fixes
Summary: [Flatpak] Refactoring and drive-by fixes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-08 08:21 PST by Philippe Normand
Modified: 2018-11-09 02:54 PST (History)
6 users (show)

See Also:

Attachments
Patch (26.92 KB, patch)
2018-11-08 08:45 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (26.93 KB, patch)
2018-11-08 08:50 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (27.65 KB, patch)
2018-11-08 09:34 PST, Philippe Normand 		mcatanzaro: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2018-11-08 08:21:39 PST 
.
Comment 1 Philippe Normand 2018-11-08 08:45:15 PST 
Created attachment 354241 [details]
Patch
Comment 2 Philippe Normand 2018-11-08 08:50:37 PST 
Created attachment 354242 [details]
Patch
Comment 3 Thibault Saunier 2018-11-08 09:07:04 PST 
Comment on attachment 354242 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354242&action=review

Loogs good otherwise.

> Tools/flatpak/flatpakutils.py:722
> +            env_vars.update(extra_env_vars)

Don't you want extra_env_vars to be forward no matter what? Here you will forward then only if they match `env_var_prefixes_to_keep` or `env_var_prefixes_to_keep` afaict.
Comment 4 Philippe Normand 2018-11-08 09:17:37 PST 
Comment on attachment 354242 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354242&action=review

>> Tools/flatpak/flatpakutils.py:722
>> +            env_vars.update(extra_env_vars)
> 
> Don't you want extra_env_vars to be forward no matter what? Here you will forward then only if they match `env_var_prefixes_to_keep` or `env_var_prefixes_to_keep` afaict.

Only if they match `env_var_prefixes_to_keep`. I have another patch for later that makes use of that feature, adding a new env var in `env_var_prefixes_to_keep` :)
Comment 5 Philippe Normand 2018-11-08 09:18:49 PST 
Comment on attachment 354242 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354242&action=review

>>> Tools/flatpak/flatpakutils.py:722
>>> +            env_vars.update(extra_env_vars)
>> 
>> Don't you want extra_env_vars to be forward no matter what? Here you will forward then only if they match `env_var_prefixes_to_keep` or `env_var_prefixes_to_keep` afaict.
> 
> Only if they match `env_var_prefixes_to_keep`. I have another patch for later that makes use of that feature, adding a new env var in `env_var_prefixes_to_keep` :)

Sorry, I meant `env_vars_to_keep` instead of `env_var_prefixes_to_keep`
Comment 6 Philippe Normand 2018-11-08 09:34:35 PST 
Created attachment 354244 [details]
Patch
Comment 7 Philippe Normand 2018-11-09 02:54:00 PST 
Committed r238025: <https://trac.webkit.org/changeset/238025>
Comment 8 Radar WebKit Bug Importer 2018-11-09 02:54:23 PST 
<rdar://problem/45939618>