Bug 191418 – HTML form validation bubble disappears

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

The bubble is not visible when the invalid form control is scrolled into view.

Example:
https://www.epson.eu/robots-contest#enter

[Chris Dumez]

Please provide reproduction steps.

Hi,

It appeared on Safari 12.

1. Submit a form with an invalid field which is outside the viewport.
2. The invalid field is scrolled into view.
3. The balloon with the error message is instantly dismissed and cannot be seen.

http://jsfiddle.net/cs4mjyzL/4/

<form>
    <input type=text required>
    <div style="height:100vh"></div>
    <button>Submit</button>
</form>

[Chris Dumez]

Ok, I can reproduce with this jsfiddle. I tried to go as far back as WebKit r232000 and the issue was already happening.

[Chris Dumez]

1   0x106b242f3 WebKit::WebValidationMessageClient::hideValidationMessage(WebCore::Element const&)
2   0x108d3a7c0 WebCore::FrameView::viewportContentsChanged()
3   0x108d44299 WebCore::FrameView::scrollTo(WebCore::IntPoint const&)
4   0x108deb868 WebCore::ScrollView::setScrollOffset(WebCore::IntPoint const&)
5   0x108deff92 WebCore::ScrollableArea::scrollPositionChanged(WebCore::IntPoint const&)
6   0x108df03aa WebCore::ScrollableArea::setScrollOffsetFromAnimation(WebCore::IntPoint const&)
7   0x108de86c4 WebCore::ScrollAnimator::notifyPositionChanged(WebCore::FloatSize const&)
8   0x107d51172 WebCore::ScrollAnimatorMac::immediateScrollToPosition(WebCore::FloatPoint const&, WebCore::ScrollClamping)
9   0x107d51073 WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation(WebCore::FloatPoint const&, WebCore::ScrollClamping)
10  0x108dea7b7 WebCore::ScrollView::updateScrollbars(WebCore::IntPoint const&)
11  0x108debf0b WebCore::ScrollView::setScrollPosition(WebCore::IntPoint const&)
12  0x108d3641c WebCore::FrameView::setScrollPosition(WebCore::IntPoint const&)
13  0x109087582 WebCore::RenderLayer::scrollRectToVisible(WebCore::LayoutRect const&, bool, WebCore::ScrollRectToVisibleOptions const&)
14  0x109087329 WebCore::RenderLayer::scrollRectToVisible(WebCore::LayoutRect const&, bool, WebCore::ScrollRectToVisibleOptions const&)
15  0x109087329 WebCore::RenderLayer::scrollRectToVisible(WebCore::LayoutRect const&, bool, WebCore::ScrollRectToVisibleOptions const&)
16  0x1090d74f5 WebCore::RenderObject::scrollRectToVisible(WebCore::LayoutRect const&, bool, WebCore::ScrollRectToVisibleOptions const&)
17  0x1089d9de9 WebCore::FrameSelection::revealSelection(WebCore::SelectionRevealMode, WebCore::ScrollAlignment const&, WebCore::RevealExtentOption)
18  0x1089d9142 WebCore::FrameSelection::updateAndRevealSelection(WebCore::AXTextStateChangeIntent const&)
19  0x1089d6a57 WebCore::FrameSelection::appearanceUpdateTimerFired()
20  0x108df8ba9 WebCore::ThreadTimers::sharedTimerFiredInternal()
21  0x108e406df WebCore::timerFired(__CFRunLoopTimer*, void*)

[Chris Dumez]

Created attachment 354277 [details]
Patch

[Chris Dumez]

Created attachment 354279 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 354279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354279&action=review

> Source/WebCore/html/HTMLFormControlElement.cpp:523
> +    callOnMainThread([this, protectedThis = makeRef(*this)] {

Kinda hokey.

[Chris Dumez]

Created attachment 354286 [details]
Patch

[Chris Dumez]

Created attachment 354293 [details]
Patch

[EWS Watchlist]

Comment on attachment 354293 [details]
Patch

Attachment 354293 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9915900

New failing tests:
fast/forms/validation-messages.html

[EWS Watchlist]

Created attachment 354300 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Chris Dumez]

Created attachment 354347 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 354347 [details]
Patch

Clearing flags on attachment: 354347

Committed r238038: <https://trac.webkit.org/changeset/238038>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45946340>

[Ryan Haddad]

accessibility/ios-simulator/form-control-validation-message.html is failing on iOS Simulator after this change:
https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r238041%20(862)/results.html

[Chris Dumez]

(In reply to Ryan Haddad from comment #16)
> accessibility/ios-simulator/form-control-validation-message.html is failing
> on iOS Simulator after this change:
> https://build.webkit.org/results/
> Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r238041%20(862)/
> results.html

<https://trac.webkit.org/changeset/238066>