Bug 191416 – [Win] UDis86Disassembler.cpp: warning: format specifies type 'unsigned long' but the argument has type 'uintptr_t' (aka 'unsigned long long')

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Fujii Hironori]

[Win] UDis86Disassembler.cpp: warning: format specifies type 'unsigned long' but the argument has type 'uintptr_t' (aka 'unsigned long long')

MSVC reports following compilation warning:

> c:\webkit\ga\source\javascriptcore\disassembler\udis86disassembler.cpp(52): warning C4477: 'snprintf' : format string '%lx' requires an argument of type 'unsigned long', but variadic argument 1 has type 'uintptr_t' (compiling source file C:\webkit\ga\WebKitBuild\Debug\DerivedSources\JavaScriptCore\unified-sources\UnifiedSource55.cpp)
> c:\webkit\ga\source\javascriptcore\disassembler\udis86disassembler.cpp(52): note: consider using '%llx' in the format string (compiling source file C:\webkit\ga\WebKitBuild\Debug\DerivedSources\JavaScriptCore\unified-sources\UnifiedSource55.cpp)
> c:\webkit\ga\source\javascriptcore\disassembler\udis86disassembler.cpp(52): note: consider using '%Ix' in the format string (compiling source file C:\webkit\ga\WebKitBuild\Debug\DerivedSources\JavaScriptCore\unified-sources\UnifiedSource55.cpp)
> c:\webkit\ga\source\javascriptcore\disassembler\udis86disassembler.cpp(52): note: consider using '%I64x' in the format string (compiling source file C:\webkit\ga\WebKitBuild\Debug\DerivedSources\JavaScriptCore\unified-sources\UnifiedSource55.cpp)

Clang-cl reports following compilation warning:

> In file included from DerivedSources\JavaScriptCore\unified-sources\UnifiedSource55.cpp:4:
> ..\..\Source\JavaScriptCore\disassembler/UDis86Disassembler.cpp(52,55):  warning: format specifies type 'unsigned long' but the argument has type 'uintptr_t' (aka 'unsigned long long') [-Wformat]
>         snprintf(pcString, sizeof(pcString), "0x%lx", static_cast<uintptr_t>(currentPC));
>                                                 ~~~   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                                                 %llx
> 1 warning generated.

This code has been introduced in Bug 190273.

[Fujii Hironori]

Created attachment 354218 [details]
Patch

[Fujii Hironori]

Comment on attachment 354218 [details]
Patch

Clearing flags on attachment: 354218

Committed r238011: <https://trac.webkit.org/changeset/238011>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45930615>