Bug 191410 - [Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists
Summary: [Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-07 19:17 PST by Wenson Hsieh
Modified: 2018-11-09 12:52 PST (History)
7 users (show)

See Also:


Attachments
Patch (52.47 KB, patch)
2018-11-08 19:34 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Fix some typos. (52.89 KB, patch)
2018-11-08 20:44 PST, Wenson Hsieh
dino: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (52.69 KB, patch)
2018-11-09 11:37 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-11-07 19:17:59 PST
This would make it easier for Mail to implement list editing behaviors using WebKit2.
Comment 1 Wenson Hsieh 2018-11-07 19:18:20 PST
<rdar://problem/45898610>
Comment 2 Wenson Hsieh 2018-11-08 19:34:08 PST
Created attachment 354304 [details]
Patch
Comment 3 Wenson Hsieh 2018-11-08 20:19:42 PST
> In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphoneos/DerivedSources/WebKit2/unified-sources/UnifiedSource29.cpp:3:
> /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/WebPageProxy.cpp:1762:44: error: no member named 'IncreaseListLevel' in namespace 'Messages::WebPage'
>         m_process->send(Messages::WebPage::IncreaseListLevel(), m_pageID);
>                         ~~~~~~~~~~~~~~~~~~~^
> /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/WebPageProxy.cpp:1768:44: error: no member named 'DecreaseListLevel' in namespace 'Messages::WebPage'
>         m_process->send(Messages::WebPage::DecreaseListLevel(), m_pageID);
>                         ~~~~~~~~~~~~~~~~~~~^
> /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/WebPageProxy.cpp:1774:44: error: no member named 'ChangeListType' in namespace 'Messages::WebPage'
>         m_process->send(Messages::WebPage::ChangeListType(), m_pageID);
>                         ~~~~~~~~~~~~~~~~~~~^
> 3 errors generated.

It's not terribly clear to me why the iOS device build is failing, whereas iOS sim builds.
Comment 4 Wenson Hsieh 2018-11-08 20:44:08 PST
Created attachment 354308 [details]
Fix some typos.
Comment 5 WebKit Commit Bot 2018-11-09 11:32:16 PST Comment hidden (obsolete)
Comment 6 Wenson Hsieh 2018-11-09 11:37:25 PST
Created attachment 354361 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2018-11-09 12:16:42 PST
Comment on attachment 354361 [details]
Patch for landing

Clearing flags on attachment: 354361

Committed r238050: <https://trac.webkit.org/changeset/238050>