Bug 191405 - REGRESSION(r236705): Web Inspector: wrong text color for selected DataGrid row
Summary: REGRESSION(r236705): Web Inspector: wrong text color for selected DataGrid row
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-07 16:02 PST by Nikita Vasilyev
Modified: 2018-11-07 18:00 PST (History)
4 users (show)

See Also:


Attachments
[Image] Bug (51.58 KB, image/png)
2018-11-07 16:02 PST, Nikita Vasilyev
no flags Details
Patch (1.48 KB, patch)
2018-11-07 16:07 PST, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
[Screen recording] Bug (5.13 MB, video/quicktime)
2018-11-07 16:34 PST, Nikita Vasilyev
no flags Details
Patch (1.51 KB, patch)
2018-11-07 17:20 PST, Nikita Vasilyev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2018-11-07 16:02:32 PST
Created attachment 354174 [details]
[Image] Bug

For both Dark Mode mode and Light Mode, the text color should be white.

Regressed in https://trac.webkit.org/changeset/236705/webkit#file5
Comment 1 Radar WebKit Bug Importer 2018-11-07 16:03:36 PST
<rdar://problem/45893283>
Comment 2 Nikita Vasilyev 2018-11-07 16:07:00 PST
Created attachment 354175 [details]
Patch
Comment 3 Nikita Vasilyev 2018-11-07 16:34:46 PST
Created attachment 354179 [details]
[Screen recording] Bug
Comment 4 Matt Baker 2018-11-07 17:06:10 PST
Comment on attachment 354175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354175&action=review

> Source/WebInspectorUI/UserInterface/Views/DataGrid.css:429
> +    color: white;

Should this just be `color: var(--selected-text-color);`?
Comment 5 Nikita Vasilyev 2018-11-07 17:11:48 PST
(In reply to Matt Baker from comment #4)
> Comment on attachment 354175 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=354175&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/DataGrid.css:429
> > +    color: white;
> 
> Should this just be `color: var(--selected-text-color);`?

--selected-foreground-color, yes.
Comment 6 Nikita Vasilyev 2018-11-07 17:20:25 PST
Created attachment 354186 [details]
Patch
Comment 7 Matt Baker 2018-11-07 17:22:19 PST
Comment on attachment 354186 [details]
Patch

r=me
Comment 8 WebKit Commit Bot 2018-11-07 18:00:57 PST
Comment on attachment 354186 [details]
Patch

Clearing flags on attachment: 354186

Committed r237973: <https://trac.webkit.org/changeset/237973>
Comment 9 WebKit Commit Bot 2018-11-07 18:00:58 PST
All reviewed patches have been landed.  Closing bug.