Bug 191404 - [GTK] Test gardening
Summary: [GTK] Test gardening
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-07 15:47 PST by Alicia Boya García
Modified: 2018-11-08 03:22 PST (History)
2 users (show)

See Also:


Attachments
Patch (8.29 KB, patch)
2018-11-07 15:49 PST, Alicia Boya García
aboya: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (8.35 KB, patch)
2018-11-07 15:50 PST, Alicia Boya García
no flags Details | Formatted Diff | Diff
Patch (8.35 KB, patch)
2018-11-08 02:39 PST, Alicia Boya García
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2018-11-07 15:47:03 PST
.
Comment 1 Alicia Boya García 2018-11-07 15:49:07 PST
Created attachment 354172 [details]
Patch
Comment 2 Alicia Boya García 2018-11-07 15:50:54 PST
Created attachment 354173 [details]
Patch for landing
Comment 3 WebKit Commit Bot 2018-11-07 15:52:50 PST
Comment on attachment 354173 [details]
Patch for landing

Rejecting attachment 354173 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 354173, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/9900769
Comment 4 Alicia Boya García 2018-11-08 02:39:27 PST
Created attachment 354228 [details]
Patch
Comment 5 WebKit Commit Bot 2018-11-08 03:22:06 PST
Comment on attachment 354228 [details]
Patch

Clearing flags on attachment: 354228

Committed r237984: <https://trac.webkit.org/changeset/237984>
Comment 6 WebKit Commit Bot 2018-11-08 03:22:08 PST
All reviewed patches have been landed.  Closing bug.