Bug 191396 - [Cocoa] Fix failing imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html test
Summary: [Cocoa] Fix failing imported/w3c/web-platform-tests/media-source/mediasource-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-07 13:40 PST by Jer Noble
Modified: 2019-04-16 09:28 PDT (History)
7 users (show)

See Also:


Attachments
Patch (64.34 KB, patch)
2018-11-07 13:50 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.33 MB, application/zip)
2018-11-07 14:48 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews101 for mac-sierra (2.43 MB, application/zip)
2018-11-07 14:52 PST, EWS Watchlist
no flags Details
Patch for landing (64.14 KB, patch)
2018-11-07 15:41 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-sierra (2.49 MB, application/zip)
2018-11-07 16:32 PST, EWS Watchlist
no flags Details
Patch for landing (65.53 KB, patch)
2018-11-07 16:52 PST, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-11-07 13:40:21 PST
[Cocoa] Fix failing imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html test
Comment 1 Radar WebKit Bug Importer 2018-11-07 13:49:39 PST
<rdar://problem/45887823>
Comment 2 Jer Noble 2018-11-07 13:49:49 PST
FYI: I plan on submitting the web-platform-test part of this patch as a pull-request to the web-platform-test repo.
Comment 3 Jer Noble 2018-11-07 13:50:42 PST
Created attachment 354143 [details]
Patch
Comment 4 Jer Noble 2018-11-07 14:17:46 PST
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/13973
Comment 5 EWS Watchlist 2018-11-07 14:48:06 PST Comment hidden (obsolete)
Comment 6 EWS Watchlist 2018-11-07 14:48:07 PST Comment hidden (obsolete)
Comment 7 EWS Watchlist 2018-11-07 14:52:32 PST Comment hidden (obsolete)
Comment 8 EWS Watchlist 2018-11-07 14:52:34 PST Comment hidden (obsolete)
Comment 9 Jer Noble 2018-11-07 15:27:50 PST
The Sierra bots don't support HEVC decode; I'll have to update the expected results to be >=HighSierra.
Comment 10 Jer Noble 2018-11-07 15:41:30 PST
Created attachment 354171 [details]
Patch for landing
Comment 11 EWS Watchlist 2018-11-07 16:32:08 PST
Comment on attachment 354171 [details]
Patch for landing

Attachment 354171 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9900915

New failing tests:
imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html
Comment 12 EWS Watchlist 2018-11-07 16:32:10 PST
Created attachment 354178 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 13 Jer Noble 2018-11-07 16:52:24 PST
Created attachment 354181 [details]
Patch for landing
Comment 14 WebKit Commit Bot 2018-11-09 09:25:00 PST
Comment on attachment 354181 [details]
Patch for landing

Clearing flags on attachment: 354181

Committed r238035: <https://trac.webkit.org/changeset/238035>
Comment 15 WebKit Commit Bot 2018-11-09 09:25:02 PST
All reviewed patches have been landed.  Closing bug.
Comment 16 Truitt Savell 2018-12-07 13:10:49 PST
This test is still failing imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fmedia-source%2Fmediasource-changetype-play.html
Comment 17 Ryosuke Niwa 2019-04-15 20:24:28 PDT
(In reply to Truitt Savell from comment #16)
> This test is still failing
> imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html
> 
> History:
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fmedia-
> source%2Fmediasource-changetype-play.html

Can we file a new bug to track this?
Comment 18 Truitt Savell 2019-04-16 09:28:41 PDT
(In reply to Ryosuke Niwa from comment #17)
> (In reply to Truitt Savell from comment #16)
> > This test is still failing
> > imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html
> > 
> > History:
> > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> > html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fmedia-
> > source%2Fmediasource-changetype-play.html
> 
> Can we file a new bug to track this?

Bug: https://bugs.webkit.org/show_bug.cgi?id=190976