Bug 191395 – Resource Load Statistics: Enable cap on partitioned cache max age

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[John Wilander]

We need a patch to turn this on.

[Radar WebKit Bug Importer]

<rdar://problem/45885977>

[John Wilander]

Created attachment 354156 [details]
Patch

[Chris Dumez]

Comment on attachment 354156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354156&action=review

> Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.cpp:839
>      RunLoop::main().dispatch([store = makeRef(m_store), seconds] () {

updateCacheMaxAgeCap(); ?

[John Wilander]

(In reply to Chris Dumez from comment #3)
> Comment on attachment 354156 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=354156&action=review
> 
> > Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.cpp:839
> >      RunLoop::main().dispatch([store = makeRef(m_store), seconds] () {
> 
> updateCacheMaxAgeCap(); ?

Yes, that's a nice enhancement. I tried first to chain them the other way around but decided I didn't want to set the member variable on every call to updateCacheMaxAgeCap().

Thanks for the review!

[John Wilander]

I will wait for the bots to run the tests before landing.

[John Wilander]

The Mac ImageOnlyFailure test issue is unrelated.

[John Wilander]

Created attachment 354170 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 354170 [details]
Patch for landing

Clearing flags on attachment: 354170

Committed r237949: <https://trac.webkit.org/changeset/237949>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.