Bug 191392 - Click and touch event listeners on the body don't work
Summary: Click and touch event listeners on the body don't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-07 12:39 PST by zalan
Modified: 2018-11-13 09:07 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.88 KB, patch)
2018-11-07 12:42 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (7.67 KB, patch)
2018-11-07 14:28 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-11-07 12:39:39 PST 
rdar://problem/5844416
Comment 1 zalan 2018-11-07 12:42:17 PST 
Created attachment 354130 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-11-07 13:26:43 PST 
Comment on attachment 354130 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354130&action=review

I think it's worth adding a test for touch handlers.

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=191392

Radar.

> LayoutTests/fast/events/click-handler-on-body-simple.html:13
> +		return;

Tabs?

> LayoutTests/fast/events/click-handler-on-body-simple.html:19
> +		result.innerHTML = "clicked";

Tab
Comment 3 zalan 2018-11-07 14:28:06 PST 
Created attachment 354152 [details]
Patch
Comment 4 WebKit Commit Bot 2018-11-07 19:33:38 PST 
Comment on attachment 354152 [details]
Patch

Clearing flags on attachment: 354152

Committed r237978: <https://trac.webkit.org/changeset/237978>
Comment 5 WebKit Commit Bot 2018-11-07 19:33:39 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-11-07 19:34:22 PST 
<rdar://problem/45898877>
Comment 7 Brent Fulgham 2018-11-13 09:07:08 PST 
Note: This is still
rdar://problem/5844416