Bug 191382 - [SVG2]: Add bounding-box keyword to pointer-events
Summary: [SVG2]: Add bounding-box keyword to pointer-events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Schulze
URL:
Keywords: InRadar
Depends on:
Blocks: 191292
  Show dependency treegraph
 
Reported: 2018-11-07 10:15 PST by Dirk Schulze
Modified: 2019-10-22 12:57 PDT (History)
20 users (show)

See Also:


Attachments
Patch (57.74 KB, patch)
2018-11-07 10:24 PST, Dirk Schulze
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-sierra (2.70 MB, application/zip)
2018-11-07 11:26 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.66 MB, application/zip)
2018-11-07 11:52 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews205 for win-future (13.42 MB, application/zip)
2018-11-07 13:25 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews202 for win-future (13.48 MB, application/zip)
2018-11-07 15:18 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews115 for mac-sierra (3.41 MB, application/zip)
2018-11-07 16:37 PST, EWS Watchlist
no flags Details
Patch (69.54 KB, patch)
2019-10-22 06:31 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews212 for win-future (14.36 MB, application/zip)
2019-10-22 08:31 PDT, EWS Watchlist
no flags Details
Patch (124.97 KB, patch)
2019-10-22 10:25 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2018-11-07 10:15:35 PST
Add support for bounding-box keyword for the the pointer-events CSS property.

https://www.w3.org/TR/SVG2/interact.html#PointerEventsProperty
Comment 1 Dirk Schulze 2018-11-07 10:24:40 PST
Created attachment 354108 [details]
Patch
Comment 2 EWS Watchlist 2018-11-07 11:26:19 PST
Comment on attachment 354108 [details]
Patch

Attachment 354108 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9895596

New failing tests:
svg/custom/pointer-events-text-css-transform.svg
Comment 3 EWS Watchlist 2018-11-07 11:26:20 PST
Created attachment 354113 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 EWS Watchlist 2018-11-07 11:52:42 PST
Comment on attachment 354108 [details]
Patch

Attachment 354108 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9895718

New failing tests:
svg/custom/pointer-events-text-css-transform.svg
Comment 5 EWS Watchlist 2018-11-07 11:52:43 PST
Created attachment 354121 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 EWS Watchlist 2018-11-07 13:25:01 PST
Comment on attachment 354108 [details]
Patch

Attachment 354108 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9896938

New failing tests:
svg/custom/pointer-events-image-css-transform.svg
svg/custom/pointer-events-image.svg
svg/custom/pointer-events-text.svg
svg/custom/pointer-events-path.svg
svg/custom/pointer-events-text-css-transform.svg
Comment 7 EWS Watchlist 2018-11-07 13:25:13 PST
Created attachment 354137 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 8 EWS Watchlist 2018-11-07 15:18:32 PST
Comment on attachment 354108 [details]
Patch

Attachment 354108 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9898887

New failing tests:
svg/custom/pointer-events-text.svg
svg/custom/pointer-events-text-css-transform.svg
webanimations/leak-document-with-web-animation.html
svg/custom/pointer-events-path.svg
svg/custom/pointer-events-image-css-transform.svg
svg/custom/pointer-events-image.svg
Comment 9 EWS Watchlist 2018-11-07 15:18:44 PST
Created attachment 354164 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment 10 EWS Watchlist 2018-11-07 16:37:37 PST
Comment on attachment 354108 [details]
Patch

Attachment 354108 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9900151

New failing tests:
svg/custom/pointer-events-text-css-transform.svg
Comment 11 EWS Watchlist 2018-11-07 16:37:39 PST
Created attachment 354180 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 12 Dean Jackson 2018-11-12 10:18:21 PST
Comment on attachment 354108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354108&action=review

> Source/WebCore/css/CSSValueKeywords.in:994
> +bounding-box

I wonder why CSSValueKeywords.in isn't generated from CSSProperties.json?

> LayoutTests/platform/mac/svg/custom/pointer-events-path-expected.txt:664
> +          chunk 1 text run 1 at (390.00,640.00) startOffset 0 endOffset 4 width 29.34: "miss"
> +      RenderSVGRect {rect} at (0,0) size 0x0 [fill={[type=SOLID] [color=#FFA500]}] [x=442.00] [y=600.00] [width=50.00] [height=50.00]
> +      RenderSVGText {text} at (447,606) size 30x18 contains 1 chunk(s)

Yikes. Why are all these non-text dumps?
Comment 13 Simon Fraser (smfr) 2019-05-21 11:49:58 PDT
We should clean this up and land it.
Comment 14 Radar WebKit Bug Importer 2019-05-21 11:50:07 PDT
<rdar://problem/50994138>
Comment 15 Radar WebKit Bug Importer 2019-05-21 11:50:08 PDT
<rdar://problem/50994132>
Comment 16 Dirk Schulze 2019-10-22 06:31:12 PDT
Created attachment 381540 [details]
Patch
Comment 17 EWS Watchlist 2019-10-22 08:31:57 PDT
Comment on attachment 381540 [details]
Patch

Attachment 381540 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13163015

New failing tests:
svg/custom/pointer-events-image-css-transform.svg
svg/custom/pointer-events-image.svg
svg/custom/pointer-events-text-css-transform.svg
svg/custom/pointer-events-path.svg
svg/custom/pointer-events-text.svg
Comment 18 EWS Watchlist 2019-10-22 08:31:59 PDT
Created attachment 381546 [details]
Archive of layout-test-results from ews212 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 19 Dirk Schulze 2019-10-22 10:25:22 PDT
Created attachment 381559 [details]
Patch
Comment 20 WebKit Commit Bot 2019-10-22 12:57:39 PDT
Comment on attachment 381559 [details]
Patch

Clearing flags on attachment: 381559

Committed r251444: <https://trac.webkit.org/changeset/251444>
Comment 21 WebKit Commit Bot 2019-10-22 12:57:41 PDT
All reviewed patches have been landed.  Closing bug.