Bug 191382 – [SVG2]: Add bounding-box keyword to pointer-events

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Dirk Schulze]

Add support for bounding-box keyword for the the pointer-events CSS property.

https://www.w3.org/TR/SVG2/interact.html#PointerEventsProperty

[Dirk Schulze]

Created attachment 354108 [details]
Patch

[EWS Watchlist]

Comment on attachment 354108 [details]
Patch

Attachment 354108 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9895596

New failing tests:
svg/custom/pointer-events-text-css-transform.svg

[EWS Watchlist]

Created attachment 354113 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 354108 [details]
Patch

Attachment 354108 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9895718

New failing tests:
svg/custom/pointer-events-text-css-transform.svg

[EWS Watchlist]

Created attachment 354121 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 354108 [details]
Patch

Attachment 354108 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9896938

New failing tests:
svg/custom/pointer-events-image-css-transform.svg
svg/custom/pointer-events-image.svg
svg/custom/pointer-events-text.svg
svg/custom/pointer-events-path.svg
svg/custom/pointer-events-text-css-transform.svg

[EWS Watchlist]

Created attachment 354137 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[EWS Watchlist]

Comment on attachment 354108 [details]
Patch

Attachment 354108 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9898887

New failing tests:
svg/custom/pointer-events-text.svg
svg/custom/pointer-events-text-css-transform.svg
webanimations/leak-document-with-web-animation.html
svg/custom/pointer-events-path.svg
svg/custom/pointer-events-image-css-transform.svg
svg/custom/pointer-events-image.svg

[EWS Watchlist]

Created attachment 354164 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[EWS Watchlist]

Comment on attachment 354108 [details]
Patch

Attachment 354108 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9900151

New failing tests:
svg/custom/pointer-events-text-css-transform.svg

[EWS Watchlist]

Created attachment 354180 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Dean Jackson]

Comment on attachment 354108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354108&action=review

> Source/WebCore/css/CSSValueKeywords.in:994
> +bounding-box

I wonder why CSSValueKeywords.in isn't generated from CSSProperties.json?

> LayoutTests/platform/mac/svg/custom/pointer-events-path-expected.txt:664
> +          chunk 1 text run 1 at (390.00,640.00) startOffset 0 endOffset 4 width 29.34: "miss"
> +      RenderSVGRect {rect} at (0,0) size 0x0 [fill={[type=SOLID] [color=#FFA500]}] [x=442.00] [y=600.00] [width=50.00] [height=50.00]
> +      RenderSVGText {text} at (447,606) size 30x18 contains 1 chunk(s)

Yikes. Why are all these non-text dumps?

[Simon Fraser (smfr)]

We should clean this up and land it.

[Radar WebKit Bug Importer]

<rdar://problem/50994138>

[Radar WebKit Bug Importer]

<rdar://problem/50994132>

[Dirk Schulze]

Created attachment 381540 [details]
Patch

[EWS Watchlist]

Comment on attachment 381540 [details]
Patch

Attachment 381540 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13163015

New failing tests:
svg/custom/pointer-events-image-css-transform.svg
svg/custom/pointer-events-image.svg
svg/custom/pointer-events-text-css-transform.svg
svg/custom/pointer-events-path.svg
svg/custom/pointer-events-text.svg

[EWS Watchlist]

Created attachment 381546 [details]
Archive of layout-test-results from ews212 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Dirk Schulze]

Created attachment 381559 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 381559 [details]
Patch

Clearing flags on attachment: 381559

Committed r251444: <https://trac.webkit.org/changeset/251444>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.