Bug 191375 - 32-bit JSC test failure: stress/regexp-compile-oom.js
Summary: 32-bit JSC test failure: stress/regexp-compile-oom.js
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-07 09:35 PST by Ryan Haddad
Modified: 2018-11-26 11:59 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.07 KB, patch)
2018-11-26 11:09 PST, Michael Saboff
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2018-11-07 09:35:39 PST
The following failure is seen on the 32-bit JSC test bot:

Running stress/regexp-exec-effect-after-exception.js.default
stress/regexp-compile-oom.js.default: Got the following failures:
stress/regexp-compile-oom.js.default: Running () => { deepRE.exec("x"); }, expected OOM exception, but didn't get one
stress/regexp-compile-oom.js.default: Running () => { deepRE.test("x"); }, expected OOM exception, but didn't get one
stress/regexp-compile-oom.js.default: Running () => { "x".match(deepRE); }, expected OOM exception, but didn't get one
stress/regexp-compile-oom.js.default: Running () => { "x".match(deepGlobalRE); }, expected OOM exception, but didn't get one
stress/regexp-compile-oom.js.default: Running () => { "x".replace(deepGlobalRE, ""); }, expected OOM exception, but didn't get one
stress/regexp-compile-oom.js.default: Running () => { "x".replace(deepGlobalRE, "X"); }, expected OOM exception, but didn't get one
stress/regexp-compile-oom.js.default: Running () => { "x".replace(deepGlobalRE, () => { return "X" }); }, expected: "Error: Out of memory: Invalid regular expression: too many nested disjunctions" but got "RangeError: Maximum call stack size exceeded."
stress/regexp-compile-oom.js.default: Running () => { "x".search(deepRE); }, expected OOM exception, but didn't get one
stress/regexp-compile-oom.js.default: Exception: Got failures
stress/regexp-compile-oom.js.default: ERROR: Unexpected exit code: 3
FAIL: stress/regexp-compile-oom.js.default

https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/2854
Comment 1 Ryan Haddad 2018-11-08 13:37:24 PST
Updating title. It is stress/regexp-compile-oom.js.default that is failing.
Comment 2 Radar WebKit Bug Importer 2018-11-09 12:12:22 PST
<rdar://problem/45952167>
Comment 3 Michael Saboff 2018-11-26 11:09:03 PST
Created attachment 355657 [details]
Patch
Comment 4 Mark Lam 2018-11-26 11:10:41 PST
Comment on attachment 355657 [details]
Patch

rs=me
Comment 5 WebKit Commit Bot 2018-11-26 11:59:50 PST
Comment on attachment 355657 [details]
Patch

Clearing flags on attachment: 355657

Committed r238508: <https://trac.webkit.org/changeset/238508>
Comment 6 WebKit Commit Bot 2018-11-26 11:59:52 PST
All reviewed patches have been landed.  Closing bug.