Bug 191362 – XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

POST requests made through the WKURLSchemeHandler get an empty POST payload in the task's request.
This leads to lack of data passed on to the handler from WKWebView.

[Alex Christensen]

I feel like this has been recently fixed, but I'm not sure.  In what version are you seeing this issue?

This is true in iOS 12.1 and also in the latest commit I have from the WebKit source - 7ac42d35cb98a00f22847ba51503489dbeb9ab49

[Patrick Yang]

This reproduces for me in an iOS 12.2 simulator built from XCode 10.2.1.

[Patrick Yang]

Created attachment 368095 [details]
minimal repro iOS app

Minimal repro iOS app.

Prints !! to console when the webview is loaded, demonstrating that the request is being forwarded to the WKURLSchemeHandler.  The printed request body is nil.

[Brady Eidson]

(In reply to Alex Christensen from comment #1)
> I feel like this has been recently fixed, but I'm not sure.  In what version
> are you seeing this issue?

Yup we fixed it and have a passing test for the fix.

Form POST navigations work great.

The test app is an XHR POST which follows a different code path and is indeed broken

(People this is why giving as much information as possible - especially repro test cases - is important!)

I’m almost done with a fix.

[Brady Eidson]

In my upcoming fix, POSTing a blob via XHR will still be broken.

See https://bugs.webkit.org/show_bug.cgi?id=197237

[Brady Eidson]

Retitle for clarity:
XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body

[Brady Eidson]

Created attachment 368170 [details]
Patch

[EWS Watchlist]

Attachment 368170 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:585:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:590:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:601:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:602:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:606:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:611:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:629:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 7 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 368170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368170&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:653
> +            printf("%u %u %u %u %u %u %u %u\n", ((char*)task.request.HTTPBody.bytes)[0], ((char*)task.request.HTTPBody.bytes)[1], ((char*)task.request.HTTPBody.bytes)[2], ((char*)task.request.HTTPBody.bytes)[3], ((char*)task.request.HTTPBody.bytes)[4], ((char*)task.request.HTTPBody.bytes)[5], ((char*)task.request.HTTPBody.bytes)[6], ((char*)task.request.HTTPBody.bytes)[7]);

:(

[Brady Eidson]

(In reply to Alex Christensen from comment #10)
> Comment on attachment 368170 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=368170&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:653
> > +            printf("%u %u %u %u %u %u %u %u\n", ((char*)task.request.HTTPBody.bytes)[0], ((char*)task.request.HTTPBody.bytes)[1], ((char*)task.request.HTTPBody.bytes)[2], ((char*)task.request.HTTPBody.bytes)[3], ((char*)task.request.HTTPBody.bytes)[4], ((char*)task.request.HTTPBody.bytes)[5], ((char*)task.request.HTTPBody.bytes)[6], ((char*)task.request.HTTPBody.bytes)[7]);
> 
> :(

Yup - Have the fix and will upload it for landing after this current patch clears EWS.

[Brady Eidson]

Created attachment 368177 [details]
Patch

[EWS Watchlist]

Attachment 368177 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:585:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:590:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:601:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:602:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:606:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:611:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:629:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 7 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 368177 [details]
Patch

Clearing flags on attachment: 368177

Committed r244617: <https://trac.webkit.org/changeset/244617>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50183483>

[[e-mail]]

I feel like this bug is not fixed for online web loading in WKWebView. In this case, I am still getting an empty HTTP body in the methods of WKURLSchemeHandler. Please find my use case below.

1. Loading below URL in WKWebView
[self.webView loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:@"http://www.colligoapp.com"]]];

2. After that, I am getting an empty HTTP body in the methods of WKURLSchemeHandler. I am unable to authenticate this URL using the correct credentials. I am facing this issue in all iOS versions (iOS 15 beta/14/13/12).

Please confirm any resolution if possible.