Bug 191357 - [WK1] Tests for smooth scrolling of a window fail
Summary: [WK1] Tests for smooth scrolling of a window fail
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
: 231627 (view as bug list)
Depends on: 188043
Blocks:
  Show dependency treegraph
 
Reported: 2018-11-07 04:24 PST by Frédéric Wang (:fredw)
Modified: 2021-10-13 09:55 PDT (History)
4 users (show)

See Also:


Attachments
Patch (6.56 KB, patch)
2021-10-12 21:23 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2018-11-07 04:24:05 PST
Smooth scroll behavior seems to somewhat work with the patch for bug 188043, but the tests still have some issues on WK1 (especially the one scrolling a window).

imported/w3c/web-platform-tests/css/cssom-view/scroll-behavior-element.html
imported/w3c/web-platform-tests/css/cssom-view/scroll-behavior-main-frame-root.html
imported/w3c/web-platform-tests/css/cssom-view/scroll-behavior-main-frame-window.html
imported/w3c/web-platform-tests/css/cssom-view/scroll-behavior-smooth-positions.html
imported/w3c/web-platform-tests/css/cssom-view/scroll-behavior-subframe-root.html
imported/w3c/web-platform-tests/css/cssom-view/scroll-behavior-subframe-window.html
Comment 1 Frédéric Wang (:fredw) 2018-11-09 01:28:45 PST
(In reply to Frédéric Wang (:fredw) from comment #0)
> Smooth scroll behavior seems to somewhat work with the patch for bug 188043,
> but the tests still have some issues on WK1 (especially the one scrolling a
> window).

One of the issue of the case "Aborting smooth scrolling with instant scrolling" that also happened on WK1 because I had forgotten to modify one function. So actually, the 4 failing tests are all related to scrolling a window, which I guess is somewhat different on WK1:

imported/w3c/web-platform-tests/css/cssom-view/scroll-behavior-main-frame-root.html
imported/w3c/web-platform-tests/css/cssom-view/scroll-behavior-main-frame-window.html
imported/w3c/web-platform-tests/css/cssom-view/scroll-behavior-subframe-root.html
imported/w3c/web-platform-tests/css/cssom-view/scroll-behavior-subframe-window.html
Comment 2 Simon Fraser (smfr) 2021-10-12 21:13:37 PDT
*** Bug 231627 has been marked as a duplicate of this bug. ***
Comment 3 Simon Fraser (smfr) 2021-10-12 21:23:25 PDT
Created attachment 441037 [details]
Patch
Comment 4 EWS 2021-10-13 09:54:27 PDT
Committed r284097 (242925@main): <https://commits.webkit.org/242925@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441037 [details].
Comment 5 Radar WebKit Bug Importer 2021-10-13 09:55:18 PDT
<rdar://problem/84203271>