Bug 191348 – run-bindings-tests is timing out in some WinCairo bots

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Fujii Hironori]

[WinCairo] run-bindings-tests is timing out in some bots

This issue is happening on wincairo-wkl-release-tests-02, but on wincairo-wkl-release-tests-01.

For example,

https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/2426/steps/bindings-generation-tests/logs/stdio

> command timed out: 1200 seconds without output running ['python', './Tools/Scripts/run-bindings-tests'], attempting to kill
> program finished with exit code 1
> elapsedTime=1200.300000


If I set a env var PYTHONUNBUFFERED=1 in wincairo-wkl-release-tests-02, it passed.

https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/2430/steps/bindings-generation-tests/logs/stdio

> PYTHONUNBUFFERED=1
(...)
> All tests PASS!
> program finished with exit code 0
> elapsedTime=2069.417000

[Fujii Hironori]

BuildBot kills run-bindings-tests if it outputs nothing for 20 minutes.
run-bindings-tests runs very slowly in WinCairo Docker.
It takes more than 30 minutes to complete.
And, Python buffers the progress output.

[Fujii Hironori]

Created attachment 354073 [details]
Patch

[Ross Kirsling]

Seems reasonable to me.

[Brent Fulgham]

Geoff, Filip, any objection to adding this flush? Seems reasonable.

[Fujii Hironori]

Review, please.

[Fujii Hironori]

Comment on attachment 354073 [details]
Patch

Clearing flags on attachment: 354073

Committed r238081: <https://trac.webkit.org/changeset/238081>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45977718>