Bug 191348 - run-bindings-tests is timing out in some WinCairo bots
Summary: run-bindings-tests is timing out in some WinCairo bots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-07 00:17 PST by Fujii Hironori
Modified: 2018-11-11 18:03 PST (History)
11 users (show)

See Also:

Attachments
Patch (1.57 KB, patch)
2018-11-07 01:18 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-11-07 00:17:05 PST 
[WinCairo] run-bindings-tests is timing out in some bots

This issue is happening on wincairo-wkl-release-tests-02, but on wincairo-wkl-release-tests-01.

For example,

https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/2426/steps/bindings-generation-tests/logs/stdio

> command timed out: 1200 seconds without output running ['python', './Tools/Scripts/run-bindings-tests'], attempting to kill
> program finished with exit code 1
> elapsedTime=1200.300000


If I set a env var PYTHONUNBUFFERED=1 in wincairo-wkl-release-tests-02, it passed.

https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/2430/steps/bindings-generation-tests/logs/stdio

> PYTHONUNBUFFERED=1
(...)
> All tests PASS!
> program finished with exit code 0
> elapsedTime=2069.417000
Comment 1 Fujii Hironori 2018-11-07 00:19:51 PST 
BuildBot kills run-bindings-tests if it outputs nothing for 20 minutes.
run-bindings-tests runs very slowly in WinCairo Docker.
It takes more than 30 minutes to complete.
And, Python buffers the progress output.
Comment 2 Fujii Hironori 2018-11-07 01:18:59 PST 
Created attachment 354073 [details]
Patch
Comment 3 Ross Kirsling 2018-11-07 08:47:26 PST 
Seems reasonable to me.
Comment 4 Brent Fulgham 2018-11-07 08:53:22 PST 
Geoff, Filip, any objection to adding this flush? Seems reasonable.
Comment 5 Fujii Hironori 2018-11-09 00:26:44 PST 
Review, please.
Comment 6 Fujii Hironori 2018-11-11 18:01:55 PST 
Comment on attachment 354073 [details]
Patch

Clearing flags on attachment: 354073

Committed r238081: <https://trac.webkit.org/changeset/238081>
Comment 7 Fujii Hironori 2018-11-11 18:01:58 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-11-11 18:03:28 PST 
<rdar://problem/45977718>