Bug 191347 – Custom test group form should use commit set map before customization as the behavior of radio buttons.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

Custom test group form should use commit set map before customization as the behavior of radio buttons.

Created attachment 354064 [details]
Patch

Comment on attachment 354064 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354064&action=review

> Websites/perf.webkit.org/browser-tests/customizable-test-group-form-tests.js:143
> +
> +

Will remove those two extra blank lines.

Tracked in <rdar://problem/4586649>

[Ryosuke Niwa]

Comment on attachment 354064 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354064&action=review

> Websites/perf.webkit.org/public/v3/components/customizable-test-group-form.js:353
> -ComponentBase.defineElement('customizable-test-group-form', CustomizableTestGroupForm);
> +ComponentBase.defineElement('customizable-test-group-form', CustomizableTestGroupForm);

What happened here? Adding a new line??

Comment on attachment 354064 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354064&action=review

>> Websites/perf.webkit.org/public/v3/components/customizable-test-group-form.js:353
>> +ComponentBase.defineElement('customizable-test-group-form', CustomizableTestGroupForm);
> 
> What happened here? Adding a new line??

I removed a blank line after this line.

Landed in r237950

(In reply to dewei_zhu from comment #3)
> Tracked in <rdar://problem/4586649>

Missing one digit. The actual tracking radar is <rdar://problem/45866496>