Bug 191347 - Custom test group form should use commit set map before customization as the behavior of radio buttons.
Summary: Custom test group form should use commit set map before customization as the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: dewei_zhu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-06 22:24 PST by dewei_zhu
Modified: 2018-11-07 16:31 PST (History)
2 users (show)

See Also:

Attachments
Patch (14.85 KB, patch)
2018-11-06 22:28 PST, dewei_zhu 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2018-11-06 22:24:41 PST 
Custom test group form should use commit set map before customization as the behavior of radio buttons.
Comment 1 dewei_zhu 2018-11-06 22:28:28 PST 
Created attachment 354064 [details]
Patch
Comment 2 dewei_zhu 2018-11-06 22:35:09 PST 
Comment on attachment 354064 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354064&action=review

> Websites/perf.webkit.org/browser-tests/customizable-test-group-form-tests.js:143
> +
> +

Will remove those two extra blank lines.
Comment 3 dewei_zhu 2018-11-06 22:40:09 PST 
Tracked in <rdar://problem/4586649>
Comment 4 Ryosuke Niwa 2018-11-07 15:31:24 PST 
Comment on attachment 354064 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354064&action=review

> Websites/perf.webkit.org/public/v3/components/customizable-test-group-form.js:353
> -ComponentBase.defineElement('customizable-test-group-form', CustomizableTestGroupForm);
> +ComponentBase.defineElement('customizable-test-group-form', CustomizableTestGroupForm);

What happened here? Adding a new line??
Comment 5 dewei_zhu 2018-11-07 16:22:18 PST 
Comment on attachment 354064 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354064&action=review

>> Websites/perf.webkit.org/public/v3/components/customizable-test-group-form.js:353
>> +ComponentBase.defineElement('customizable-test-group-form', CustomizableTestGroupForm);
> 
> What happened here? Adding a new line??

I removed a blank line after this line.
Comment 6 dewei_zhu 2018-11-07 16:30:48 PST 
Landed in r237950
Comment 7 dewei_zhu 2018-11-07 16:31:50 PST 
(In reply to dewei_zhu from comment #3)
> Tracked in <rdar://problem/4586649>

Missing one digit. The actual tracking radar is <rdar://problem/45866496>