RESOLVED FIXED 191342
Web Inspector: Debugger Popover does not work when paused in Worker 
https://bugs.webkit.org/show_bug.cgi?id=191342
Summary Web Inspector: Debugger Popover does not work when paused in Worker
Joseph Pecoraro
Reported 2018-11-06 18:52:09 PST
Debugger Popover does not work when paused in Worker Steps to Reproduce: 1. Pause in a worker's onmessage 2. Hover over something like `event` => No popover Notes: • Wrong target seems to be getting used for popover related code.
Attachments
[PATCH] Proposed Fix (2.85 KB, patch)
2018-11-06 18:54 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2018-11-06 18:54:02 PST
Created attachment 354045 [details] [PATCH] Proposed Fix
Devin Rousso
Comment 2 2018-11-06 22:08:05 PST
Comment on attachment 354045 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=354045&action=review > Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:1728 > + let target = WI.debuggerManager.activeCallFrame ? WI.debuggerManager.activeCallFrame.target : this.target; NIT: considering that `WI.debuggerManager.activeCallFrame` is used in a few places in this function, making it into a separate variable seems reasonable (e.g. `activeCallFrame` or even just `callFrame`)
Devin Rousso
Comment 3 2018-11-06 22:08:25 PST
(In reply to Devin Rousso from comment #2) Forgot, r=me :P
WebKit Commit Bot
Comment 4 2018-11-08 14:43:59 PST
Comment on attachment 354045 [details] [PATCH] Proposed Fix Clearing flags on attachment: 354045 Committed r238003: <https://trac.webkit.org/changeset/238003>
WebKit Commit Bot
Comment 5 2018-11-08 14:44:01 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-11-08 14:44:29 PST
<rdar://problem/45924333>
Note You need to log in before you can comment on or make changes to this bug.