Bug 191342 - Web Inspector: Debugger Popover does not work when paused in Worker
Summary: Web Inspector: Debugger Popover does not work when paused in Worker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-06 18:52 PST by Joseph Pecoraro
Modified: 2018-11-08 14:44 PST (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.85 KB, patch)
2018-11-06 18:54 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-11-06 18:52:09 PST 
Debugger Popover does not work when paused in Worker

Steps to Reproduce:
1. Pause in a worker's onmessage
2. Hover over something like `event`
  => No popover

Notes:
• Wrong target seems to be getting used for popover related code.
Comment 1 Joseph Pecoraro 2018-11-06 18:54:02 PST 
Created attachment 354045 [details]
[PATCH] Proposed Fix
Comment 2 Devin Rousso 2018-11-06 22:08:05 PST 
Comment on attachment 354045 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=354045&action=review

> Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:1728
> +        let target = WI.debuggerManager.activeCallFrame ? WI.debuggerManager.activeCallFrame.target : this.target;

NIT: considering that `WI.debuggerManager.activeCallFrame` is used in a few places in this function, making it into a separate variable seems reasonable (e.g. `activeCallFrame` or even just `callFrame`)
Comment 3 Devin Rousso 2018-11-06 22:08:25 PST 
(In reply to Devin Rousso from comment #2)
Forgot, r=me :P
Comment 4 WebKit Commit Bot 2018-11-08 14:43:59 PST 
Comment on attachment 354045 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 354045

Committed r238003: <https://trac.webkit.org/changeset/238003>
Comment 5 WebKit Commit Bot 2018-11-08 14:44:01 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-11-08 14:44:29 PST 
<rdar://problem/45924333>