Bug 191336 – Add some basic pointer events tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dean Jackson]

Add some basic pointer events tests

[Radar WebKit Bug Importer]

<rdar://problem/45858574>

[Dean Jackson]

Created attachment 354021 [details]
Patch

[Wenson Hsieh]

Comment on attachment 354021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354021&action=review

> LayoutTests/fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html:54
> +                testRunner.runUIScript(getUIScript(50, 200, 60, 250, 0.3), function(result) { });

I think these tests would be a bit cleaner if we used ui-helper.js and basic-gestures.js, with async-await.

> LayoutTests/fast/events/pointer/ios/tap-gives-pointerdown-pointerup.html:47
> +                testRunner.runUIScript(getUIScript(50, 200), function(result) { });

Ditto.

[Dean Jackson]

Committed r237902: <https://trac.webkit.org/changeset/237902>

[Ryan Haddad]

These two tests are timing out on macOS WK1 bots:

fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html
fast/events/pointer/ios/tap-gives-pointerdown-pointerup.html

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r237902%20(13861)/results.html

[Ryan Haddad]

(In reply to Ryan Haddad from comment #5)
> These two tests are timing out on macOS WK1 bots:
> 
> fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html
> fast/events/pointer/ios/tap-gives-pointerdown-pointerup.html
> 
> https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/
> r237902%20(13861)/results.html
Oh, just realized these are for iOS. I guess we need to skip this directory in TestExpectations.

[Ryan Haddad]

(In reply to Ryan Haddad from comment #6)
> (In reply to Ryan Haddad from comment #5)
> Oh, just realized these are for iOS. I guess we need to skip this directory
> in TestExpectations.

Done in https://trac.webkit.org/changeset/237928/webkit