Bug 191336 - Add some basic pointer events tests
Summary: Add some basic pointer events tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-06 15:28 PST by Dean Jackson
Modified: 2018-11-07 09:32 PST (History)
3 users (show)

See Also:


Attachments
Patch (7.62 KB, patch)
2018-11-06 16:08 PST, Dean Jackson
wenson_hsieh: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2018-11-06 15:28:10 PST
Add some basic pointer events tests
Comment 1 Radar WebKit Bug Importer 2018-11-06 15:31:41 PST
<rdar://problem/45858574>
Comment 2 Dean Jackson 2018-11-06 16:08:09 PST
Created attachment 354021 [details]
Patch
Comment 3 Wenson Hsieh 2018-11-06 16:15:10 PST
Comment on attachment 354021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354021&action=review

> LayoutTests/fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html:54
> +                testRunner.runUIScript(getUIScript(50, 200, 60, 250, 0.3), function(result) { });

I think these tests would be a bit cleaner if we used ui-helper.js and basic-gestures.js, with async-await.

> LayoutTests/fast/events/pointer/ios/tap-gives-pointerdown-pointerup.html:47
> +                testRunner.runUIScript(getUIScript(50, 200), function(result) { });

Ditto.
Comment 4 Dean Jackson 2018-11-06 16:46:50 PST
Committed r237902: <https://trac.webkit.org/changeset/237902>
Comment 5 Ryan Haddad 2018-11-06 17:48:06 PST
These two tests are timing out on macOS WK1 bots:

fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html
fast/events/pointer/ios/tap-gives-pointerdown-pointerup.html

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r237902%20(13861)/results.html
Comment 6 Ryan Haddad 2018-11-06 17:50:10 PST
(In reply to Ryan Haddad from comment #5)
> These two tests are timing out on macOS WK1 bots:
> 
> fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html
> fast/events/pointer/ios/tap-gives-pointerdown-pointerup.html
> 
> https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/
> r237902%20(13861)/results.html
Oh, just realized these are for iOS. I guess we need to skip this directory in TestExpectations.
Comment 7 Ryan Haddad 2018-11-07 09:32:08 PST
(In reply to Ryan Haddad from comment #6)
> (In reply to Ryan Haddad from comment #5)
> Oh, just realized these are for iOS. I guess we need to skip this directory
> in TestExpectations.

Done in https://trac.webkit.org/changeset/237928/webkit