Bug 191330 - IntersectionObserverEntry doesn't keep JS wrappers of rects alive
Summary: IntersectionObserverEntry doesn't keep JS wrappers of rects alive
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ali Juma
URL:
Keywords: InRadar
Depends on:
Blocks: 159475
  Show dependency treegraph
 
Reported: 2018-11-06 14:22 PST by Ali Juma
Modified: 2018-11-07 10:32 PST (History)
12 users (show)

See Also:


Attachments
Patch (7.40 KB, patch)
2018-11-07 06:46 PST, Ali Juma
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ali Juma 2018-11-06 14:22:32 PST
Following up on rniwa's review comment in bug 190235, we need to make sure that wrappers of the DOMRectReadOnly objects in IntersectionObserverEntry get visited during GC.
Comment 1 Ali Juma 2018-11-07 06:46:43 PST
Created attachment 354087 [details]
Patch
Comment 2 Chris Dumez 2018-11-07 09:43:19 PST
Comment on attachment 354087 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2018-11-07 10:30:38 PST
Comment on attachment 354087 [details]
Patch

Clearing flags on attachment: 354087

Committed r237929: <https://trac.webkit.org/changeset/237929>
Comment 4 WebKit Commit Bot 2018-11-07 10:30:40 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-11-07 10:32:30 PST
<rdar://problem/45879997>