Bug 191327 - Make generic MainThreadSharedTimer implementation
Summary: Make generic MainThreadSharedTimer implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-06 13:08 PST by Don Olmstead
Modified: 2018-11-07 10:50 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.45 KB, patch)
2018-11-06 13:09 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (5.79 KB, patch)
2018-11-06 13:48 PST, Don Olmstead 		mcatanzaro: review+
Details | Formatted Diff | Diff
Patch (6.19 KB, patch)
2018-11-07 09:21 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-11-06 13:08:08 PST 
Currently MainThreadSharedTimerGlib.cpp could be used for other platforms.
Comment 1 Don Olmstead 2018-11-06 13:09:32 PST 
Created attachment 353995 [details]
Patch
Comment 2 Don Olmstead 2018-11-06 13:48:50 PST 
Created attachment 354000 [details]
Patch
Comment 3 Michael Catanzaro 2018-11-06 17:10:39 PST 
Comment on attachment 354000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354000&action=review

> Source/WebCore/platform/glib/MainThreadSharedTimerGLib.cpp:-3
> - * Copyright (C) 2006-2016 Apple Inc.  All rights reserved.
> - * Copyright (C) 2006 Michael Emmel mike.emmel@gmail.com

You should move the original copyright lines too.
Comment 4 Don Olmstead 2018-11-07 09:21:39 PST 
Created attachment 354099 [details]
Patch
Comment 5 WebKit Commit Bot 2018-11-07 10:49:21 PST 
Comment on attachment 354099 [details]
Patch

Clearing flags on attachment: 354099

Committed r237930: <https://trac.webkit.org/changeset/237930>
Comment 6 WebKit Commit Bot 2018-11-07 10:49:23 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-11-07 10:50:31 PST 
<rdar://problem/45881095>