WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
191327
Make generic MainThreadSharedTimer implementation
https://bugs.webkit.org/show_bug.cgi?id=191327
Summary
Make generic MainThreadSharedTimer implementation
Don Olmstead
Reported
2018-11-06 13:08:08 PST
Currently MainThreadSharedTimerGlib.cpp could be used for other platforms.
Attachments
Patch
(3.45 KB, patch)
2018-11-06 13:09 PST
,
Don Olmstead
no flags
Details
Formatted Diff
Diff
Patch
(5.79 KB, patch)
2018-11-06 13:48 PST
,
Don Olmstead
mcatanzaro
: review+
Details
Formatted Diff
Diff
Patch
(6.19 KB, patch)
2018-11-07 09:21 PST
,
Don Olmstead
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Don Olmstead
Comment 1
2018-11-06 13:09:32 PST
Created
attachment 353995
[details]
Patch
Don Olmstead
Comment 2
2018-11-06 13:48:50 PST
Created
attachment 354000
[details]
Patch
Michael Catanzaro
Comment 3
2018-11-06 17:10:39 PST
Comment on
attachment 354000
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=354000&action=review
> Source/WebCore/platform/glib/MainThreadSharedTimerGLib.cpp:-3 > - * Copyright (C) 2006-2016 Apple Inc. All rights reserved. > - * Copyright (C) 2006 Michael Emmel
mike.emmel@gmail.com
You should move the original copyright lines too.
Don Olmstead
Comment 4
2018-11-07 09:21:39 PST
Created
attachment 354099
[details]
Patch
WebKit Commit Bot
Comment 5
2018-11-07 10:49:21 PST
Comment on
attachment 354099
[details]
Patch Clearing flags on attachment: 354099 Committed
r237930
: <
https://trac.webkit.org/changeset/237930
>
WebKit Commit Bot
Comment 6
2018-11-07 10:49:23 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2018-11-07 10:50:31 PST
<
rdar://problem/45881095
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug