RESOLVED FIXED 191311
ShadowRoot should have styleSheets property 
https://bugs.webkit.org/show_bug.cgi?id=191311
Summary ShadowRoot should have styleSheets property
Ryosuke Niwa
Reported 2018-11-06 10:19:09 PST
See https://github.com/w3c/csswg-drafts/issues/548 We need to have styleSheets defined on ShadowRoot.
Attachments
Adds the support (15.82 KB, patch)
2018-11-29 20:17 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed the build (15.83 KB, patch)
2018-11-29 21:37 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-sierra (2.58 MB, application/zip)
2018-11-29 22:45 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews105 for mac-sierra-wk2 (3.11 MB, application/zip)
2018-11-29 22:53 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews115 for mac-sierra (2.26 MB, application/zip)
2018-11-29 23:39 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.41 MB, application/zip)
2018-11-30 00:34 PST, EWS Watchlist 		no flags
Details
Rebaselined the tests (17.54 KB, patch)
2018-11-30 11:47 PST, Ryosuke Niwa 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-11-28 22:33:55 PST
<rdar://problem/46333290>
Ryosuke Niwa
Comment 2 2018-11-29 20:17:03 PST
Created attachment 356117 [details] Adds the support
Ryosuke Niwa
Comment 3 2018-11-29 21:37:41 PST
Created attachment 356129 [details] Fixed the build
EWS Watchlist
Comment 4 2018-11-29 22:45:47 PST
Comment on attachment 356129 [details] Fixed the build Attachment 356129 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10210311 New failing tests: imported/w3c/web-platform-tests/css/cssom/selectorText-modification-restyle-002.html imported/w3c/web-platform-tests/css/css-scoping/stylesheet-title-002.html
EWS Watchlist
Comment 5 2018-11-29 22:45:49 PST
Created attachment 356144 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 6 2018-11-29 22:53:00 PST
Comment on attachment 356129 [details] Fixed the build Attachment 356129 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10210315 New failing tests: imported/w3c/web-platform-tests/css/cssom/selectorText-modification-restyle-002.html imported/w3c/web-platform-tests/css/css-scoping/stylesheet-title-002.html
EWS Watchlist
Comment 7 2018-11-29 22:53:02 PST
Created attachment 356145 [details] Archive of layout-test-results from ews105 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 8 2018-11-29 23:39:14 PST
Comment on attachment 356129 [details] Fixed the build Attachment 356129 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10210493 New failing tests: imported/w3c/web-platform-tests/css/cssom/selectorText-modification-restyle-002.html imported/w3c/web-platform-tests/css/css-scoping/stylesheet-title-002.html
EWS Watchlist
Comment 9 2018-11-29 23:39:15 PST
Created attachment 356152 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 10 2018-11-30 00:34:54 PST
Comment on attachment 356129 [details] Fixed the build Attachment 356129 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10210822 New failing tests: imported/w3c/web-platform-tests/css/cssom/selectorText-modification-restyle-002.html imported/w3c/web-platform-tests/css/css-scoping/stylesheet-title-002.html
EWS Watchlist
Comment 11 2018-11-30 00:34:56 PST
Created attachment 356157 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Ryosuke Niwa
Comment 12 2018-11-30 11:47:11 PST
Created attachment 356210 [details] Rebaselined the tests
Antti Koivisto
Comment 13 2018-11-30 15:31:00 PST
r=me
Ryosuke Niwa
Comment 14 2018-11-30 15:32:21 PST
Thanks!
Ryosuke Niwa
Comment 15 2018-11-30 15:33:41 PST
Committed r238758: <https://trac.webkit.org/changeset/238758>
Note You need to log in before you can comment on or make changes to this bug.